Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoved snapUpdate.sh and replaced with inline command #65579
Conversation
Kedstar99
force-pushed the
Kedstar99:snapFix
branch
2 times, most recently
from
7454f38
to
296b8fb
Dec 22, 2018
Kedstar99
force-pushed the
Kedstar99:snapFix
branch
from
296b8fb
to
4c02c55
Dec 22, 2018
alexandrudima
assigned
joaomoreno and
Tyriar
Dec 23, 2018
joaomoreno
added this to the December/January 2019 milestone
Jan 3, 2019
joaomoreno
added
install-update
linux
snap
labels
Jan 3, 2019
joaomoreno
merged commit eb69d48
into
Microsoft:master
Jan 28, 2019
This comment has been minimized.
This comment has been minimized.
|
Yeah let's take this! Thanks! |
Kedstar99
deleted the
Kedstar99:snapFix
branch
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Kedstar99 commentedDec 22, 2018
This patch removes the need for snapUpdate.sh. This has the following benefits:
+Simplifies the build process by avoiding setting and moving the file.
+Avoids creating a new shell that simply spawns another shell environment.
+Simplifies the update mechanism by removing the need to track the existence of snapUpdate.sh.
+Keeps the logic for snapUpdate.sh close to updateService.snap.ts
I have tested the code changes to spawn within a Node environment in vscode console and it correctly spawns another instance of vscode.
If this patch isn't wanted, there are still some changes that may be suggested. For example, currently updateService.linux.ts is calling snapUpdate.sh but the default Linux builds aren't being built with the script. Similarly, the comment for executing snapUpdate.sh isn't correct.
Running the command 'grep -nr --exclude-dir=".git" 'snapUpdate.sh' .' produces no results so I assume I have removed all references.