New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted another ~70 test files to strictNullChecks #65672

Merged
merged 2 commits into from Dec 28, 2018

Conversation

Projects
None yet
2 participants
@JoshuaKGoldberg
Copy link
Contributor

JoshuaKGoldberg commented Dec 25, 2018

These are the remaining test files in #65233 that didn't require any changes to non-test file types. I'll send those in separately.

Most changes were automatic and small (!s).
The only non-trival change is that extHostSearch.ts needs an interface for its test data.

Again used TypeStat when possible per #65581. I'm happy to split this up into smaller PRs if you'd prefer!

Edit: Build is failing on files I didn't touch for parts that don't interact with my changes 馃槙. Very confusing. Does anybody know why?

JoshuaKGoldberg added some commits Dec 25, 2018

Converted another ~70 test files to strictNullChecks
These are the remaining test files that didn't require any changes to non-test file types. I'll send those in separately.

Most changes were automatic and small (`!`s).
The only non-trival change is that `extHostSearch.ts` needs an interface for its test data.

Again used [TypeStat](https://github.com/JoshuaKGoldberg/TypeStat) when possible per #65581. I'm happy to split this up into smaller PRs if you'd prefer!
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Dec 28, 2018

Thanks!

Those test files include files that are not yet strict null checked. The test file changes look good to me but I think we need to hold off on adding them to the strictNull.tsconfig until all of their imports are handled.

I'm going to merge and then revert the changes to only the tsconfing

@mjbvz mjbvz merged commit 373b441 into Microsoft:master Dec 28, 2018

1 of 2 checks passed

VS Code #20181225.3 failed
Details
license/cla All CLA requirements met.
Details

mjbvz added a commit that referenced this pull request Dec 28, 2018

Revert including some test files in strict null check build
See #65672

Not all of these files only import strict null check eligible files

@JoshuaKGoldberg JoshuaKGoldberg deleted the JoshuaKGoldberg:strict-null-checks-auto-2 branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment