New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Snippet: Consistent void tags #66072

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@mathiasvr
Copy link
Contributor

mathiasvr commented Jan 5, 2019

The snippet is inconsistent with the use of self-closing void tags such as <meta> and <meta />.

While both are valid in HTML5, I believe removing the self-closing tags are generally preferred.

@aeschli aeschli added this to the December/January 2019 milestone Jan 7, 2019

@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Jan 7, 2019

Thanks @mathiasvr !

@aeschli aeschli merged commit ed48143 into Microsoft:master Jan 10, 2019

2 checks passed

VS Code #20190105.4 succeeded
Details
license/cla All CLA requirements met.

@mathiasvr mathiasvr deleted the mathiasvr:patch-2 branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment