New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loc): fix incorrect phrasing for transparent color descriptions #66334

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@kumarharsh
Copy link
Contributor

kumarharsh commented Jan 10, 2019

The sentence 'The color must not be opaque to not hide underlying
decorations' is incorrect. This PR replaces 'to not hide' with
'so as not to hide'. See the link below for why:
https://english.stackexchange.com/questions/45265/use-of-so-as-not-to

Closes #66333

fix(loc): fix incorrect phrasing for transparent color descriptions
The sentence 'The color must not be opaque to not hide underlying
decorations' is incorrect. This PR replaces 'to not hide' with
'so as not to hide'. See the link below for why:
https://english.stackexchange.com/questions/45265/use-of-so-as-not-to

Closes #66333
@fatcerberus

This comment has been minimized.

Copy link

fatcerberus commented Jan 10, 2019

I wouldn't say it's incorrect in this particular case (despite the SE link above--the example given there uses "not to" whereas here it's "to not" which clears up the ambiguity), but I will agree the current wording is very awkward so this is indeed an improvement. 👍

@kumarharsh

This comment has been minimized.

Copy link
Contributor Author

kumarharsh commented Jan 10, 2019

Yeah, I'm no linguist so maybe saying 'incorrect' is not... er... correct, but the current phrasing is awkward, especially the presence of two nots so close sent me on a trip deciphering what the text meant 😬

@aeschli aeschli merged commit 22ce181 into Microsoft:master Jan 11, 2019

2 checks passed

VS Code #20190110.28 succeeded
Details
license/cla All CLA requirements met.
Details

@aeschli aeschli added this to the December/January 2019 milestone Jan 11, 2019

@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Jan 11, 2019

Thanks @kumarharsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment