New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kill terminal from the terminal context menu #66535

Merged
merged 4 commits into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@asaf050
Copy link

asaf050 commented Jan 15, 2019

Background:

Once split terminal panel to multiple terminals, is more effective to allow user to kill a single terminal from the context menu.

In this PR:

  • Add another existing action to the terminal context menu.

@asaf050 asaf050 changed the title Allow kill terminal from the terminal's context menu Allow kill terminal from the terminal context menu Jan 15, 2019

@Tyriar
Copy link
Member

Tyriar left a comment

I actually thought this was already there 😅

Let's add a separator in between clear and kill, then this looks good to me 👍

@Tyriar Tyriar added this to the December/January 2019 milestone Jan 16, 2019

Asaf Cohen
@asaf050

This comment has been minimized.

Copy link
Author

asaf050 commented Jan 19, 2019

@Tyriar Hey :)
I've add the separator , you can have a look 👍

@Tyriar

Tyriar approved these changes Jan 24, 2019

Copy link
Member

Tyriar left a comment

Thanks for the PR @asaf050!

@Tyriar Tyriar merged commit adf0b19 into Microsoft:master Jan 24, 2019

2 checks passed

VS Code #20190119.3 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment