New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex warnings from LGTM.com #66615

Merged
merged 3 commits into from Jan 18, 2019

Conversation

Projects
None yet
5 participants
@aeyerstaylor
Copy link
Contributor

aeyerstaylor commented Jan 16, 2019

This fixes some regex warning found up on LGTM.com here.

These are mostly due to confusion about regex syntax where separating character classes with a pipe is not needed.

I think this is the correct fix in each case but I am not entirely sure as it's not always obvious whether a pipe was intended to be a member of the class or not.

In particular I am not sure about the emmet extensions.

(Disclaimer: I work for semmle, the company behind LGTM.com)

@sandy081 sandy081 requested a review from jrieken Jan 17, 2019

@jrieken jrieken assigned octref, bpasero and mjbvz and unassigned jrieken Jan 17, 2019

@octref

This comment has been minimized.

Copy link
Member

octref commented Jan 17, 2019

In the emmet case the original intention was probably for readability, but I'm fine for changing.

@octref

octref approved these changes Jan 17, 2019

@mjbvz mjbvz self-requested a review Jan 17, 2019

@bpasero bpasero requested review from octref and removed request for jrieken and octref Jan 18, 2019

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Jan 18, 2019

Down to one in markdown @mjbvz

@mjbvz mjbvz merged commit c880900 into Microsoft:master Jan 18, 2019

2 checks passed

VS Code #20190118.20 succeeded
Details
license/cla All CLA requirements met.

@mjbvz mjbvz added this to the December/January 2019 milestone Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment