New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow bottom panel to be "minimized" #67025

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@VishalMadhvani
Copy link

VishalMadhvani commented Jan 23, 2019

I wanted to be able to "minimize" the terminal panel so it just sits at the bottom of the screen without taking up too much space. Thought it would be useful to have a quick glance at the problems counter for example.

I'm not familiar with the code so starting an early pr to hopefully save me going in the wrong direction.

So far I've cloned the maximize toggle button to make it toggle between a minimized and restored state.

Panel in restored state:
screenshot 2019-01-23 at 21 29 39

Panel in Maximized state:
screenshot 2019-01-23 at 21 30 04

Panel in Minimized state:
screenshot 2019-01-23 at 21 29 50

Currently working on showing/hiding the buttons based on the state, so for example, when minimized, the maximize button shouldn't show, and vice versa, as well as not showing minimize button when the panel is positioned right as it doesn't make sense to do so.

Figured I'd start with the basics while I'm exploring the code so thoughts/insights would be very much appreciated. Thanks

@sbatten

This comment has been minimized.

Copy link
Member

sbatten commented Jan 24, 2019

@VishalMadhvani we are currently exploring changes to the overall workbench layout. Since some of your changes are currently in a file that is becoming obsolete, I think you may find it easier to approach this at a later date.

@joaomoreno @bpasero

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Jan 24, 2019

/cc @isidorn as owner of panel layout

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Jan 24, 2019

@VishalMadhvani thanks for your PR. However it is usually best to first start a conversation and only than do the coding. As in this case @sbatten is rewritting our panel layout logic and the code will be quite different and we will no longer want any "hard - coded" panel layout actions. It should behave just like the grid. Once we have that we will not need features like this IMHO, and I would not like to merge this in now becasue the whole area is deprecated.

Due to the reasons above I am closing this PR.
Hope that makes sense

@isidorn isidorn closed this Jan 24, 2019

@VishalMadhvani

This comment has been minimized.

Copy link
Author

VishalMadhvani commented Jan 24, 2019

Yeah makes sense.. I'll keep an eye out for when the grid updates land and take a look again.
thanks

@bsiegel

This comment has been minimized.

Copy link
Member

bsiegel commented Feb 8, 2019

For what it's worth, this seems like a really useful feature. I've filed #68183 to track it so that hopefully it can be implemented once the new grid layout stuff is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment