Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: Allow bottom panel to be "minimized" #67025
I wanted to be able to "minimize" the terminal panel so it just sits at the bottom of the screen without taking up too much space. Thought it would be useful to have a quick glance at the problems counter for example.
I'm not familiar with the code so starting an early pr to hopefully save me going in the wrong direction.
So far I've cloned the maximize toggle button to make it toggle between a minimized and restored state.
Currently working on showing/hiding the buttons based on the state, so for example, when minimized, the maximize button shouldn't show, and vice versa, as well as not showing minimize button when the panel is positioned right as it doesn't make sense to do so.
Figured I'd start with the basics while I'm exploring the code so thoughts/insights would be very much appreciated. Thanks
@VishalMadhvani thanks for your PR. However it is usually best to first start a conversation and only than do the coding. As in this case @sbatten is rewritting our panel layout logic and the code will be quite different and we will no longer want any "hard - coded" panel layout actions. It should behave just like the grid. Once we have that we will not need features like this IMHO, and I would not like to merge this in now becasue the whole area is deprecated.
Due to the reasons above I am closing this PR.