New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "tsc watch" task when references are used #67148

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@RomainMuller
Copy link
Contributor

RomainMuller commented Jan 26, 2019

Moves the --watch option at the end of the tsc invocation, as --build
is required to be the first option on the call.

Fixes #66875

Fix the "tsc watch" task when references are used
Moves the `--watch` option at the end of the `tsc` invocation, as `--build`
is required to be the first option on the call.

Fixes #66875
@RomainMuller

This comment has been minimized.

Copy link
Contributor Author

RomainMuller commented Jan 28, 2019

The failed check looks to have been caused by a timeout.

@mjbvz mjbvz added this to the December/January 2019 milestone Jan 28, 2019

@mjbvz mjbvz merged commit 52fb907 into Microsoft:master Jan 28, 2019

2 checks passed

VS Code #20190126.2 succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Jan 28, 2019

Thanks!

@eladb

This comment has been minimized.

Copy link

eladb commented Jan 29, 2019

Yeah! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment