Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #64669: Keep extensions' search input value after window reload #68198

Closed
wants to merge 206 commits into from

Conversation

Projects
None yet
@klymenkoo
Copy link
Contributor

commented Feb 8, 2019

This Pull Request fixes issue #64669

As discussed on the issue page, I created viewletState for searchBox in order to save value of the search box, and use it when it is re-rendered.

CC: @sandy081

@msftclas

This comment has been minimized.

Copy link

commented Feb 8, 2019

CLA assistant check
All CLA requirements met.

@kieferrm kieferrm requested a review from sandy081 Feb 11, 2019

@sandy081 sandy081 added this to the February 2019 milestone Feb 13, 2019

@sandy081 sandy081 added the extensions label Feb 13, 2019

@@ -435,7 +435,11 @@ export class ExtensionsViewlet extends ViewContainerViewlet implements IExtensio

protected saveState(): void {
const value = this.searchBox.getValue();
this.searchViewletState['query.value'] = value;
if (value.indexOf('@installed') >= 0) {

This comment has been minimized.

Copy link
@sandy081

sandy081 Feb 18, 2019

Member

May be you should use the following to check if it is an installed query or not

static isInstalledExtensionsQuery(query: string): boolean {

This comment has been minimized.

Copy link
@klymenkoo

klymenkoo Feb 18, 2019

Author Contributor

fixed it

@sandy081

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@klymenkoo Tested it and it does not work. I changed extensions viewlet to show installed extensions and did refresh. After refresh, input box shows @installed but the views were not updated

image

@klymenkoo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

@sandy081 I added triggerSearch() function if there is value in searchBox while creation. Should work now. Let me know if there is anything else needed to be fixed.

joaomoreno and others added some commits Feb 21, 2019

add functionality to hide open context menu (#64099)
* add functionality to hide open context menu
fix toggling of ... menu on windows
fix toggling of global activity bar menu on windows
fix position of global activity bar menu on windows
fixes #62413
fixes #61766

* addressing feedback

* linting error

* updating to eat mouse click to dismiss menu

* remove native context menu changes as unnecessary

* use an invisible div to block mouse

* move logic into context menu handler

* sanitize SNAP variables

* rename update.channel to update.mode

fixes #67407

* dervie status background from editor widget background
Remove delay when focusing simple find widget
Fixes #59606

This matches how the editor find widget works
@sandy081

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

@klymenkoo Thanks for the changes. Merged it by cherry picking commit by commit as I kinda messed up with merging. Thanks a lot.

@sandy081 sandy081 closed this Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.