Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for "screen cheese with long error messages" #8432

Merged
merged 2 commits into from Jun 29, 2016

Conversation

@kisstkondoros
Copy link
Contributor

kisstkondoros commented Jun 28, 2016

Since the parent element has been set to display: flex, it's children does not uses some of the css properties.
Those has been removed and subtsituted with the flex css property.

fixes #8357

Since the parent element has been set to display: flex, it's children does not uses some of the css properties.
Those has been removed and subtsituted with the flex css property.

fixes #8357
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jun 28, 2016

By analyzing the blame information on this pull request, we identified @sandy081 to be a potential reviewer

@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Jun 29, 2016

@kisstkondoros Thanks for providing a quick and nice fix. Fix looks good to me. But, if you see the checks our builds are failing due to bad indentation. Can you please fix it and re-submit the request.

Thanks

@sandy081 sandy081 merged commit c5c2489 into microsoft:master Jun 29, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Jun 29, 2016

@kisstkondoros Thanks for the fix. Merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.