New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TfsAuthenticator hangs the IDE #49

Closed
mmajcica opened this Issue Dec 27, 2016 · 13 comments

Comments

Projects
None yet
3 participants
@mmajcica

mmajcica commented Dec 27, 2016

With the version 1.111.0 of the plugin, I do see a strange behavior of the plugin. In case I do use VSTS Git source control in which I do authenticate on TFS, and then later I attempt to use TFVC, in case the authentication was already provided, IDEA IDE gets unresponsive and I do find following in my log:

2016-12-27 12:36:54,227 [  26081]   WARN - fsTelemetryInstrumentationInfo - Unable to locate property resource /telemetry/com.microsoft.alm.plugin-telemetry.properties 
2016-12-27 12:36:54,305 [  26159]   WARN - n.settings.TeamServicesSecrets - getServerContextSecrets: info was null for key:  
2016-12-27 12:36:54,414 [  26268]   WARN - n.settings.TeamServicesSecrets - getServerContextSecrets: info was null for key:  
2016-12-27 12:36:54,492 [  26346]   INFO - .checkout.VsoCheckoutPageModel - Skipping loading contexts in constructor 
2016-12-27 12:36:54,492 [  26346]   INFO - n.context.ServerContextManager - Prompting for credentials 
2016-12-27 12:36:54,492 [  26346]   INFO - ugin.authentication.AuthHelper - getAuthenticationInfoSynchronously calling authenticateAsync on https://tfs.mytfs.com/tfs 
2016-12-27 12:36:54,492 [  26346]   INFO - tion.TfsAuthenticationProvider - starting TfsAuthenticator 

In order to get it working I need remove the ServerContextState node from vsts_settings.xml file so that the plugin can request the auth again. Then it works. Same is valid for the vice versa approach, if you initially choose TFVC then try to open VSTS Git source control; TfsAuthenticator Async authentication refuses to start and hangs IDEA.

Regards,
Mario

@leantk

This comment has been minimized.

Show comment
Hide comment
@leantk

leantk Dec 28, 2016

Member

Hi @mmajcica,

Thanks for reporting the issue. There must be a problem where we reuse the login info from the Git repo for the TFVC repo since they share the same account. I'm taking a look at it and will see if I can reproduce the issue on my side. So just to clarify, you clone a Git repo and it works like expected but when you then go to clone a TFVC repo afterwards it hangs. At what point does it hang? Do you see the Checkout dialog again or do you not even get that far?

Thanks again,
-Leah

Member

leantk commented Dec 28, 2016

Hi @mmajcica,

Thanks for reporting the issue. There must be a problem where we reuse the login info from the Git repo for the TFVC repo since they share the same account. I'm taking a look at it and will see if I can reproduce the issue on my side. So just to clarify, you clone a Git repo and it works like expected but when you then go to clone a TFVC repo afterwards it hangs. At what point does it hang? Do you see the Checkout dialog again or do you not even get that far?

Thanks again,
-Leah

@mmajcica

This comment has been minimized.

Show comment
Hide comment
@mmajcica

mmajcica Dec 29, 2016

Hi @leantk,

indeed. If I do first use Git and login, clone a repo and such. Next time I do try to select the TFVC from the main screen:

2016-12-23 08_34_54-welcome to intellij idea

Then the app gets stuck, I do NOT get to even see any other window.

The same goes vice versa in case I use the TFVC then try git.

mmajcica commented Dec 29, 2016

Hi @leantk,

indeed. If I do first use Git and login, clone a repo and such. Next time I do try to select the TFVC from the main screen:

2016-12-23 08_34_54-welcome to intellij idea

Then the app gets stuck, I do NOT get to even see any other window.

The same goes vice versa in case I use the TFVC then try git.

@volnoboy

This comment has been minimized.

Show comment
Hide comment
@volnoboy

volnoboy Jan 1, 2017

I have the same issue. Did you find a fix? Same version of plugin and intellij IDEA.

volnoboy commented Jan 1, 2017

I have the same issue. Did you find a fix? Same version of plugin and intellij IDEA.

@mmajcica

This comment has been minimized.

Show comment
Hide comment
@mmajcica

mmajcica Jan 1, 2017

@volnoboy

I already mentioned a fix above in my first post:
In order to get it working I need remove the ServerContextState node from vsts_settings.xml file.

Once you remove all ServerContextState nodes from vsts_settings.xml file and restart IDEA, you will get prompted to authenticate again and it will work. Not an elegant way but it works.

Cheers,
Mario

mmajcica commented Jan 1, 2017

@volnoboy

I already mentioned a fix above in my first post:
In order to get it working I need remove the ServerContextState node from vsts_settings.xml file.

Once you remove all ServerContextState nodes from vsts_settings.xml file and restart IDEA, you will get prompted to authenticate again and it will work. Not an elegant way but it works.

Cheers,
Mario

@volnoboy

This comment has been minimized.

Show comment
Hide comment
@volnoboy

volnoboy Jan 1, 2017

I cannot locate anywhere this file vsts_settings.xml?

volnoboy commented Jan 1, 2017

I cannot locate anywhere this file vsts_settings.xml?

@mmajcica

This comment has been minimized.

Show comment
Hide comment
@mmajcica

mmajcica Jan 1, 2017

mmajcica commented Jan 1, 2017

@mmajcica

This comment has been minimized.

Show comment
Hide comment
@mmajcica

mmajcica Jan 2, 2017

@volnoboy

If you still haven't found it (which I doubt :) ) here is the path in my case:

C:\Users\majcicam\.IdeaIC2016.3\config\options

where majcicam is my user profile folder and .IdeaIC2016.3 is specific to edition and version of IDEA I'm using. Adapt it for your case.

Mario

mmajcica commented Jan 2, 2017

@volnoboy

If you still haven't found it (which I doubt :) ) here is the path in my case:

C:\Users\majcicam\.IdeaIC2016.3\config\options

where majcicam is my user profile folder and .IdeaIC2016.3 is specific to edition and version of IDEA I'm using. Adapt it for your case.

Mario

@volnoboy

This comment has been minimized.

Show comment
Hide comment
@volnoboy

volnoboy Jan 2, 2017

Thank you. Now, I found it. I was looking into .idea in my project folder.

volnoboy commented Jan 2, 2017

Thank you. Now, I found it. I was looking into .idea in my project folder.

@leantk

This comment has been minimized.

Show comment
Hide comment
@leantk

leantk Jan 3, 2017

Member

@volnoboy- we are still looking at fixing this bug permanently so you don't have this pain. We apologize. I will keep this issue updated on the progress. Thanks for your patience.

@mmajcica- thanks for pointing him to the workaround and the right path for the settings file. I'm still debugging the issue at the moment.

Member

leantk commented Jan 3, 2017

@volnoboy- we are still looking at fixing this bug permanently so you don't have this pain. We apologize. I will keep this issue updated on the progress. Thanks for your patience.

@mmajcica- thanks for pointing him to the workaround and the right path for the settings file. I'm still debugging the issue at the moment.

@leantk leantk self-assigned this Jan 3, 2017

@leantk leantk added the bug label Jan 3, 2017

@leantk

This comment has been minimized.

Show comment
Hide comment
@leantk

leantk Jan 5, 2017

Member

@mmajcica or @volnoboy,

I made a code change that fixes the issue for me but I couldn't get a true repro of the freeze so I was hoping maybe one of you could test it out for me if you are still having issues. I've attached the updated plugin build here. Please let me know if you see any change or the same thing.

plugin.idea-1.111.1-freezeFix.zip

Thanks for the help,
-Leah

Member

leantk commented Jan 5, 2017

@mmajcica or @volnoboy,

I made a code change that fixes the issue for me but I couldn't get a true repro of the freeze so I was hoping maybe one of you could test it out for me if you are still having issues. I've attached the updated plugin build here. Please let me know if you see any change or the same thing.

plugin.idea-1.111.1-freezeFix.zip

Thanks for the help,
-Leah

@mmajcica

This comment has been minimized.

Show comment
Hide comment
@mmajcica

mmajcica Jan 5, 2017

@leantk

I just tried it on two machines, different test cases and it now works as expected.
In which version of the plugin will this fix end up (1.111.1???) and when will it be available?

Thanks

mmajcica commented Jan 5, 2017

@leantk

I just tried it on two machines, different test cases and it now works as expected.
In which version of the plugin will this fix end up (1.111.1???) and when will it be available?

Thanks

@leantk

This comment has been minimized.

Show comment
Hide comment
@leantk

leantk Jan 6, 2017

Member

@mmajcica it will be version 1.111.1 and I'm looking to release it next week. I'll update this issue once it's out there to download.

Member

leantk commented Jan 6, 2017

@mmajcica it will be version 1.111.1 and I'm looking to release it next week. I'll update this issue once it's out there to download.

@leantk

This comment has been minimized.

Show comment
Hide comment
@leantk

leantk Jan 10, 2017

Member

I just released the fix under the version 1.111.1. Please reopen this issue if you see this behavior again but for now I'm going to close it since I've had 2 people verify it fixed the issue.

Member

leantk commented Jan 10, 2017

I just released the fix under the version 1.111.1. Please reopen this issue if you see this behavior again but for now I'm going to close it since I've had 2 people verify it fixed the issue.

@leantk leantk closed this Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment