Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where api-extractor failed to find node-core-library #345

Merged
merged 4 commits into from Aug 31, 2017

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented Aug 31, 2017

This is part of the fix for SPFx GitHub # 820.

The error looked like this:

TypeError: Cannot read property 'readCommentedJsonFile' of undefined
TypeError: Cannot read property 'readCommentedJsonFile' of undefined

The problem was that api-extractor recently took a dependency on node-core-library, but it was incorrectly listed as a dev dependency.

@qz2017
Copy link
Contributor

qz2017 commented Aug 31, 2017

This does not fix "TypeError: Cannot read property 'readCommentedJsonFile' of undefined". It fixes the issue about node-core-library not found

Copy link
Contributor

@qz2017 qz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@octogonz
Copy link
Collaborator Author

octogonz commented Aug 31, 2017

:shipit:

Approved with PullApprove Approved with PullApprove

@octogonz octogonz merged commit 5b708ff into master Aug 31, 2017
@nickpape nickpape deleted the pgonzal/fix-dependencies branch March 21, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants