Users/elendil326/compare versions as integers #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w is a string comparison, it should be an integer comparison.
zurdev
reviewed
Jun 14, 2018
tasks/common/apiHelper.ts
Outdated
| } | ||
|
|
||
| // Min set of common segments is equal, check for extra segments greater than zero | ||
| var longerVersion = minLengthToCompare == xParts.length ? yParts : xParts; |
There was a problem hiding this comment.
consider simplifying by pushing 0's to the lesser array, xParts or yParts, to make them equal in length
zurdev
reviewed
Jun 19, 2018
tasks/common/apiHelper.ts
Outdated
| if (diff) { | ||
| return diff; | ||
| } | ||
| var shorterVersion = []; |
There was a problem hiding this comment.
How about:
while (xParts.length < yParts.length) xParts.push('0');
while (yParts.length < xParts.length) yParts.push('0');
// Compare parts
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding version comparison as numbers rather than strings.