Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Assertion while reading redis.conf with UTF-8 bottom signature #21

Closed
JCKodel opened this Issue Oct 19, 2012 · 4 comments

Comments

Projects
None yet
3 participants

JCKodel commented Oct 19, 2012

On sds.c, line 485:

while(1) {
    /* skip blanks */
    while(*p && isspace(*p)) p++; <-------- This line fails with an assert when redis.conf has a UTF-8 bottom signure
    if (*p) {
        /* get a token */

clca commented Oct 31, 2012

Thanks for reporting this issue. We hit the same while working on the 64bit version. the fix will be submitted tomorrow.

Actually this is not a bug we found. I have been trying to find out what you mean by 'UTF-8 bottom signature'. Is this a BOM, or is it something else? Can you post an example for us to test with?

@HenryRawas HenryRawas closed this Nov 1, 2012

@HenryRawas HenryRawas reopened this Nov 1, 2012

JCKodel commented Nov 1, 2012

Sorry... It is BOM =)

As I use brazilian portuguese Windows OS (ISO-8859-1), Visual Studio saves some files as UTF-8 with a signature (ef bb bf) at first 3-bytes of text files.

That signature is throwing the assert.

Fix posted

@HenryRawas HenryRawas closed this Nov 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment