Skip to content

Conversation

@chasewilson
Copy link
Contributor

PR Summary

Fixes #5025
Updates example to show multiple VM renaming

PR Context

docs-conceptual folder

Select the type(s) of documents being changed.

Cmdlet reference & about_ topics

  • Version 7 content
  • Version 6 content
  • Version 5.1 content

Conceptual articles

  • Fundamental conceptual articles
  • Script sample articles
  • DSC articles
  • Gallery articles
  • JEA articles
  • WMF articles
  • SDK articles

PR Checklist

  • I have read the contributors guide and followed the style and process guidelines
  • PR has a meaningful title
  • PR is targeted at the staging branch
  • All relevant versions updated
  • Includes content related to issues and PRs - see Closing issues using keywords.
  • This PR is ready to merge and is not Work in Progress
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the
      title and remove the prefix when the PR is ready.

@opbld32
Copy link

opbld32 commented Nov 3, 2019

Docs Build status updates of commit 59b43fb:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/dsc/resources/authoringResourceComposite.md ✅Succeeded View (powershell-3.0)
View (powershell-4.0)
View (powershell-5.0)
View (powershell-5.1)
View (powershell-6)
View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@sdwheeler sdwheeler requested review from DCtheGeek and sdwheeler and removed request for sdwheeler November 3, 2019 17:13
@opbld31
Copy link

opbld31 commented Nov 3, 2019

Docs Build status updates of commit dfb91d3:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/dsc/resources/authoringResourceComposite.md ✅Succeeded View (powershell-3.0)
View (powershell-4.0)
View (powershell-5.0)
View (powershell-5.1)
View (powershell-6)
View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@chasewilson chasewilson changed the title Fixes #5025 - Adds multiple names to composite resource example Fixes #5025 - Adds example to show multiple VM creation Nov 3, 2019
Copy link
Contributor

@DCtheGeek DCtheGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chasewilson Update looks good and will resolve the related issue, thanks! Once you make the two formatting adjustments, this will be ready to merge. Thanks!

@opbld31
Copy link

opbld31 commented Nov 4, 2019

Docs Build status updates of commit ceddbeb:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/dsc/resources/authoringResourceComposite.md ✅Succeeded View (powershell-3.0)
View (powershell-4.0)
View (powershell-5.0)
View (powershell-5.1)
View (powershell-6)
View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Collaborator

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor fixes

chasewilson and others added 2 commits November 4, 2019 09:24
…site.md

Co-Authored-By: Sean Wheeler <sean.wheeler@microsoft.com>
Co-Authored-By: Sean Wheeler <sean.wheeler@microsoft.com>
@opbld32
Copy link

opbld32 commented Nov 4, 2019

Docs Build status updates of commit 53bc36f:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/dsc/resources/authoringResourceComposite.md ✅Succeeded View (powershell-3.0)
View (powershell-4.0)
View (powershell-5.0)
View (powershell-5.1)
View (powershell-6)
View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbld30
Copy link

opbld30 commented Nov 4, 2019

Docs Build status updates of commit 0759dfd:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/dsc/resources/authoringResourceComposite.md ✅Succeeded View (powershell-3.0)
View (powershell-4.0)
View (powershell-5.0)
View (powershell-5.1)
View (powershell-6)
View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@chasewilson
Copy link
Contributor Author

@chasewilson Update looks good and will resolve the related issue, thanks! Once you make the two formatting adjustments, this will be ready to merge. Thanks!

@DCtheGeek I believe I've updated all the comments and Thanks to @sdwheeler for catching my rookie mistake on the [!NOTE]

Copy link
Contributor

@DCtheGeek DCtheGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DCtheGeek DCtheGeek merged commit 4c05384 into MicrosoftDocs:staging Nov 4, 2019
@chasewilson chasewilson deleted the phwilsonsdw-ghi5025 branch November 4, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DSC Composite Resource - Incomplete example

6 participants