Skip to content

Conversation

@arkoppan
Copy link
Contributor

1.Corrected the statement for example where the output variable is set in a non-deployment job.
2. Added the example to reference an output variable from a deployment job.
3. Made some corrections to variable names in other examples.
4. Corrected the reference example when using resource name.

1.Corrected the statement for example where the output variable is set in a non-deployment job.
2. Added the example to reference an output variable from a deployment job.
3. Made some corrections to variable names in other examples.
4. Corrected the reference example when using resource name.
@prmerger-automator
Copy link
Contributor

@arkoppan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS
Copy link
Contributor

Jak-MS commented Sep 12, 2024

@juliakm
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@juliakm
Copy link
Collaborator

juliakm commented Sep 30, 2024

@arkoppan Thanks for your edits!

#sign-off

@Jak-MS
Copy link
Contributor

Jak-MS commented Sep 30, 2024

@arkoppan @juliakm - merging this PR #14142 has seemingly caused a merge conflict ... can you address/fix and then tag me to review again? thanks.

@Jak-MS
Copy link
Contributor

Jak-MS commented Sep 30, 2024

#hold-off

@hunyu
Copy link

hunyu commented Oct 16, 2024

Do we have an update on this @arkoppan @juliakm?

@arkoppan
Copy link
Contributor Author

@arkoppan @juliakm - merging this PR #14142 has seemingly caused a merge conflict ... can you address/fix and then tag me to review again? thanks.

@Jak-MS The changes from this PR 14142 can be overridden with the changes suggested in this PR 14141 (as the variable vmsfortesting is defined in the environment on line 478.

@hunyu @juliakm

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 21, 2024

@arkoppan @juliakm @hunyu - i have addressed the merge conflict as recommended in a previous comment. See this commit: 024697b

I'll merge this now... please double check that all the changes are as you intended, and if not open a new PR to address any issues. thanks.

@Jak-MS Jak-MS merged commit c435426 into MicrosoftDocs:main Oct 21, 2024
2 checks passed
@hunyu
Copy link

hunyu commented Nov 8, 2024

Do we know how soon PR will get published? Noticed that https://learn.microsoft.com/en-us/azure/devops/pipelines/process/deployment-jobs?view=azure-devops#support-for-output-variables is still dated May 2024. Or this is up to Doc Gate Keeper to officially release the update document?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants