Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-comment AzureKeyVault@1 secretsFilter argument #4061

Merged
merged 1 commit into from Sep 25, 2019
Merged

Un-comment AzureKeyVault@1 secretsFilter argument #4061

merged 1 commit into from Sep 25, 2019

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Apr 24, 2019

According to the docs, the secretsFilter argument is required. As such, this change un-comments the argument in the snippet to avoid potential confusion for users since having the argument commented-out may be interpreted as the argument being optional.

According to the [docs](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-key-vault?view=azure-devops#arguments), the `secretsFilter` argument is required. As such, this change un-comments the argument in the snippet to avoid potential confusion for users since having the argument commented-out may be interpreted as the argument being optional.
@PRMerger16
Copy link
Collaborator

@PRMerger16 PRMerger16 commented Apr 24, 2019

@c-w : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Copy link

@raulalvarado1 raulalvarado1 left a comment

Send express.

@steved0x steved0x merged commit 5e579ab into MicrosoftDocs:master Sep 25, 2019
1 check passed
steved0x pushed a commit that referenced this issue Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants