Un-comment AzureKeyVault@1 secretsFilter argument - #4061
Merged
Conversation
According to the [docs](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-key-vault?view=azure-devops#arguments), the `secretsFilter` argument is required. As such, this change un-comments the argument in the snippet to avoid potential confusion for users since having the argument commented-out may be interpreted as the argument being optional.
Contributor
|
Clemens Wolff (@c-w) : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
Steve Danielson (steved0x)
pushed a commit
that referenced
this pull request
Dec 14, 2021
Collect diagnostic data [UPDATE]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the docs, the
secretsFilterargument is required. As such, this change un-comments the argument in the snippet to avoid potential confusion for users since having the argument commented-out may be interpreted as the argument being optional.