New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Github' with 'GitHub' #1104

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Projects
None yet
5 participants
@ethomson
Contributor

ethomson commented Mar 20, 2017

I noticed that there was a new tutorial for Azure Active Directory with GitHub via https://twitter.com/azuread/status/843862198703312897. Exciting!

I noticed that the name of GitHub was misspelled as "Github". (Note the lowercase 'h'.) I also happened to notice that wasn't the only document where this occurred; this PR replaces all occurrences of "Github" in the docs with "GitHub".

@msftclas

This comment has been minimized.

msftclas commented Mar 20, 2017

@ethomson,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas

This comment has been minimized.

msftclas commented Mar 20, 2017

@ethomson, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@msftclas msftclas added cla-signed and removed cla-required labels Mar 20, 2017

@PRmerger

This comment has been minimized.

Collaborator

PRmerger commented Mar 20, 2017

@ethomson : Thanks for your contribution to the Azure documentation! The author, @azdocprs, has been notified to review your proposed change.

@jomolnar

This comment has been minimized.

Contributor

jomolnar commented Mar 21, 2017

@priyamohanram Please review these proposed changes. Thanks.

@priyamohanram

This comment has been minimized.

Contributor

priyamohanram commented Mar 28, 2017

@ethomson: Thank you for your contribution! Can you please fix the merge conflicts? I will mark the PR for merge right after that. Thank you again!

Replace 'Github' with 'GitHub'
The name of the Git repository hosting provider is "GitHub", not
"Github".
@ethomson

This comment has been minimized.

Contributor

ethomson commented Mar 28, 2017

@priyamohanram Sure - I rebased this on top of master - and I fixed a few new occurrences of Github.

@priyamohanram

This comment has been minimized.

Contributor

priyamohanram commented Mar 28, 2017

@ethomson : Perfect, thank you! =)

@priyamohanram

This comment has been minimized.

Contributor

priyamohanram commented Mar 28, 2017

#sign-off

@jomolnar

This comment has been minimized.

Contributor

jomolnar commented Mar 28, 2017

@ethomson @priyamohanram Thanks for this fix, and thanks for the sign-off. Merging now.

@jomolnar jomolnar merged commit 526d174 into MicrosoftDocs:master Mar 28, 2017

rajumsys pushed a commit to rajumsys/azure-docs that referenced this pull request May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment