Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenFaaS + AKS post #26396

Merged
merged 3 commits into from Mar 6, 2019

Conversation

Projects
None yet
8 participants
@alexellis
Copy link
Contributor

alexellis commented Mar 6, 2019

  • Add basic auth by default
  • Remove old section pointing to basic auth through proxy
  • Use helm chart repo instead of git clone
  • Point to workshop as next step at end
  • Create namespaces through official method

Signed-off-by: Alex Ellis alexellis2@gmail.com

cc @justindavies @squillace

Update OpenFaaS + AKS post
- Add basic auth by default
- Remove old section pointing to basic auth through proxy
- Use helm chart repo instead of git clone
- Point to workshop as next step at end
- Create namespaces through official method

Signed-off-by: Alex Ellis <alexellis2@gmail.com>
@msftclas

This comment has been minimized.

Copy link

msftclas commented Mar 6, 2019

CLA assistant check
All CLA requirements met.

kubectl create namespace openfaas-fn
# generate a random password
PASSWORD=$(head -c 12 /dev/urandom | shasum| cut -d' ' -f1)

This comment has been minimized.

@justindavies

justindavies Mar 6, 2019

Contributor

Might be good to highlight here to the reader that they should echo the password - I know it is specified later, but will help with the flow.

This comment has been minimized.

@alexellis

alexellis Mar 6, 2019

Author Contributor

This is as per the docs -> https://github.com/openfaas/faas-netes/tree/master/chart/openfaas

We're so far out I'm just trying to get us in sync.

This comment has been minimized.

@justindavies

justindavies Mar 6, 2019

Contributor

The password generation is fine, but can you explain to the end user that they can view the generated password by "echo $PASSWORD"

This comment has been minimized.

@alexellis

alexellis Mar 6, 2019

Author Contributor

I added a comment for this.

```

This password will prevent authorized access to your OpenFaaS gateway which will be exposed to the public Internet via a cloud LoadBalancer.

This comment has been minimized.

@justindavies

justindavies Mar 6, 2019

Contributor

This password will prevent unauthorized access ?

This comment has been minimized.

@alexellis

alexellis Mar 6, 2019

Author Contributor

Yes

This comment has been minimized.

@alexellis

alexellis Mar 6, 2019

Author Contributor

I can reword it.

@GitHubber17

This comment has been minimized.

Copy link
Contributor

GitHubber17 commented Mar 6, 2019

Hi @alexellis - In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just a few minutes: Sign the CLA. Thank you.

@PRMerger8

This comment has been minimized.

Copy link
Contributor

PRMerger8 commented Mar 6, 2019

@alexellis : Thanks for your contribution! The author, @justindavies, has been notified to review your proposed change.

Feedback from Justin
- echoes the password
- update language on basic auth

Signed-off-by: Alex Ellis <alexellis2@gmail.com>
@PRMerger9

This comment has been minimized.

Copy link
Contributor

PRMerger9 commented Mar 6, 2019

@alexellis : Thanks for your contribution! The author, @justindavies, has been notified to review your proposed change.

@alexellis

This comment has been minimized.

Copy link
Contributor Author

alexellis commented Mar 6, 2019

CLA should be handled now.

@justindavies
Copy link
Contributor

justindavies left a comment

Looks good!

@justindavies
Copy link
Contributor

justindavies left a comment

Thanks Alex.

@PRMerger13

This comment has been minimized.

Copy link
Contributor

PRMerger13 commented Mar 6, 2019

@GitHubber17 : Thanks for your contribution! The author, @justindavies, has been notified to review your proposed change.

@GitHubber17 GitHubber17 merged commit 5975ca4 into MicrosoftDocs:master Mar 6, 2019

1 check passed

license/cla All CLA requirements met.
Details

@alexellis alexellis deleted the alexellis:openfaas/helm_basic_auth branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.