Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACR metrics to supported metrics overview #27991

Closed

Conversation

Projects
None yet
9 participants
@tomkerkhove
Copy link
Contributor

commented Mar 26, 2019

Add ACR metrics to supported metrics overview

@PRMerger12

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@tomkerkhove : Thanks for your contribution! The author, @anirudhcavale, has been notified to review your proposed change.

Provide better documentation
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@PRMerger9

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@tomkerkhove : Thanks for your contribution! The author, @anirudhcavale, has been notified to review your proposed change.

@msyihchen

This comment has been minimized.

Copy link

commented Mar 27, 2019

Can you add OS type as RunDuration's dimension?

@tomkerkhove

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

I can, what is the value for it? Or is OS type the query parameter as well?

For what it's worth when I check in the Azure portal it's not there:
image

@msyihchen

This comment has been minimized.

Copy link

commented Mar 27, 2019

The dimension name should be BuildOsType. Storage has Metrics SuccessE2ELatency with dimensions “GeoType”, “ApiName” and “Authentication”. But those dimensions are not available in portal. So I guess we need to be consistent with storage here.

@PRMerger6

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@tomkerkhove : Thanks for your contribution! The author, @anirudhcavale, has been notified to review your proposed change.

@tomkerkhove

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Perfect, docs adapted - Thanks for letting me know @msyihchen

@msyihchen

This comment has been minimized.

Copy link

commented Mar 27, 2019

@tomkerkhove Thanks for updating and contributing!

@anirudhcavale

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@msyihchen

This comment has been minimized.

Copy link

commented Mar 27, 2019

Oh I see. We need to select a metric first and then add a filter. Dimension is part of filter. @tomkerkhove Sorry I told you the wrong thing. Storage does have those dimensions in portal but we don't. Can you revert the last commit?

@PRMerger10

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

@tomkerkhove : Thanks for your contribution! The author, @anirudhcavale, has been notified to review your proposed change.

@tomkerkhove

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

@anirudhcavale

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

#please-close the ACR metrics have been added.

@PRMerger13 PRMerger13 closed this May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.