Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casing of batch transcription options #43231

Merged
merged 3 commits into from
Jan 15, 2020
Merged

Fix casing of batch transcription options #43231

merged 3 commits into from
Jan 15, 2020

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Nov 20, 2019

Using the documented values for the PunctuationMode and ProfanityFilterMode batch-transcription options fails with HTTP 400:

Screenshot showing error with documented PunctuationMode values

Screenshot showing error with documented ProfanityFilterModeValues

Changing the casing to PascalCase fixes the bad requests.

@c-w
Fix casing of batch transcription options
69ca296 
Using the documented values for the PunctuationMode and ProfanityFilterMode batch-transcription options fails with HTTP 400:

![Screenshot showing error with documented PunctuationMode values](https://user-images.githubusercontent.com/1086421/69267726-c4ee2800-0b9b-11ea-83e3-df0218cf81b3.png)

![Screenshot showing error with documented ProfanityFilterModeValues](https://user-images.githubusercontent.com/1086421/69267873-08e12d00-0b9c-11ea-8c6e-a960b9f10c4f.png)

Changing the casing to PascalCase fixes the bad requests.
@PRMerger17
Copy link
Contributor

@c-w : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jborsecnik jborsecnik added the aq-pr-triaged tracking label for the PR review team label Nov 20, 2019
@PanosPeriorellis
Copy link
Contributor

#sign-off

@PRMerger17
Copy link
Contributor

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger17
Copy link
Contributor

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver ktoliver merged commit 69ae416 into MicrosoftDocs:master Jan 15, 2020
@c-w c-w deleted the patch-1 branch January 15, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanosPeriorellis PanosPeriorellis Awaiting requested review from PanosPeriorellis

Assignees

@PanosPeriorellis PanosPeriorellis

Labels
aq-pr-triaged tracking label for the PR review team Change sent to author cognitive-services/svc ready-to-merge speech-service/subsvc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@c-w @PRMerger17 @PanosPeriorellis @ktoliver @PRMerger13 @jborsecnik