New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major changes to OS Drive expanding approach #4325

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
6 participants
@bahreex
Contributor

bahreex commented Dec 28, 2017

With the introduction of Managed Disks in Azure, the approach for disk resizing has changed. The way to expand Managed disk size is different from Unmanaged disks. What approach and PS code is shown in this docs article is only for expanding OS drive size for Unmanaged disks. I have added the PS approach and code for expanding OS drives size for Managed disks. I have tried to keep the flow and formatting intact as per the original, and have also added the relevant section on Data Disks pertaining to Managed disks too. There were some script errors in existing PS code and some missing Info, which I corrected.

Major changes to OS Drive expanding approach
With the introduction of Managed Disks in Azure, the approach for disk resizing has changed. The way to expand Managed disk size is different from Unmanaged disks. What approach and PS code is shown in this docs article is only for expanding OS drive size for Unmanaged disks. I have added the PS approach and code for expanding OS drives size for Managed disks. I have tried to keep the flow and formatting intact as per the original, and have also added the relevant section on Data Disks pertaining to Managed disks too. There were some script errors in existing PS code and some missing Info, which I corrected.
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Dec 28, 2017

CLA assistant check
All CLA requirements met.

msftclas commented Dec 28, 2017

CLA assistant check
All CLA requirements met.

@PRmerger

This comment has been minimized.

Show comment
Hide comment
@PRmerger

PRmerger Dec 28, 2017

Collaborator

@bahreex : Thanks for your contribution to the Azure documentation! The author, @azdocprs, has been notified to review your proposed change.

Collaborator

PRmerger commented Dec 28, 2017

@bahreex : Thanks for your contribution to the Azure documentation! The author, @azdocprs, has been notified to review your proposed change.

@GitHubber17

This comment has been minimized.

Show comment
Hide comment
@GitHubber17

GitHubber17 Dec 28, 2017

Contributor

@iainfoulds - Would you review the proposed changes? Thanks

Contributor

GitHubber17 commented Dec 28, 2017

@iainfoulds - Would you review the proposed changes? Thanks

@iainfoulds

This comment has been minimized.

Show comment
Hide comment
@iainfoulds

iainfoulds Jan 3, 2018

Contributor

Thanks for the contribution, @bahreex

This include is used primarily (exclusively?) in https://docs.microsoft.com/azure/virtual-machines/windows/expand-os-disk, which is owned by @kirpasingh

Kirpa - would you be able to review the proposed changes, and review the rest of the doc for any additional updates that could be made to support Managed Disks? Thanks.

Contributor

iainfoulds commented Jan 3, 2018

Thanks for the contribution, @bahreex

This include is used primarily (exclusively?) in https://docs.microsoft.com/azure/virtual-machines/windows/expand-os-disk, which is owned by @kirpasingh

Kirpa - would you be able to review the proposed changes, and review the rest of the doc for any additional updates that could be made to support Managed Disks? Thanks.

@kirpasingh

Thank you @bahreex, changes look good to me.

@iainfoulds

This comment has been minimized.

Show comment
Hide comment
@iainfoulds

iainfoulds Jan 4, 2018

Contributor

Thanks, @kirpasingh

#sign-off

Contributor

iainfoulds commented Jan 4, 2018

Thanks, @kirpasingh

#sign-off

@GitHubber17 GitHubber17 merged commit de048ee into MicrosoftDocs:master Jan 5, 2018

1 check passed

license/cla All CLA requirements met.
Details

@bahreex bahreex deleted the bahreex:patch-4 branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment