Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jq in FHIR object id lookup instructions #58510

Merged
merged 2 commits into from Jul 8, 2020
Merged

Remove jq in FHIR object id lookup instructions #58510

merged 2 commits into from Jul 8, 2020

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 6, 2020

Currently the FHIR documentation on how to look up Azure Active Directory object IDs using the Azure CLI depends on the external tool jq to extract specific items from JSON payloads returned by the CLI.

However, the Azure CLI supports querying the JSON responses natively via --query. As such, this change updates the documentation to use --query instead of jq which removes an external tool dependency and also makes the Azure CLI snippets work on Windows.

Currently the FHIR documentation on how to look up Azure Active Directory object IDs using the Azure CLI depends on the external tool `jq` to extract specific items from JSON payloads returned by the CLI.

However, the Azure CLI supports querying the JSON responses natively via [--query](https://docs.microsoft.com/en-us/cli/azure/query-azure-cli). As such, this change updates the documentation to use `--query` instead of `jq` which removes an external tool dependency and also makes the Azure CLI snippets work on Windows.
@PRMerger20
Copy link
Collaborator

PRMerger20 commented Jul 6, 2020

@c-w : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@hansenms hansenms left a comment

Thanks for the contribution. One small comment if you could check.

@@ -25,7 +25,7 @@ $(Get-AzureADUser -Filter "UserPrincipalName eq 'myuser@consoso.com'").ObjectId
or you can use the Azure CLI:

```azurecli-interactive
az ad user show --upn-or-object-id myuser@consoso.com | jq -r .objectId
az ad user show --upn-or-object-id myuser@consoso.com --query objectId --out tsv
Copy link
Contributor

@hansenms hansenms Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the latest versions of Azure CLI uses just --id instead of --upn-or-object-id, can you validate that works for you and correct at the same time?

Copy link
Contributor Author

@c-w c-w Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed, there's a deprecation warning with the --upn-or-object-id argument:

Screenshot showing deprecation warning of --upn-or-object-id argument

I updated this to --id in 4a7e688 which returns the same result as --upn-or-object-id but without the deprecation warning:

Screenshot showing non-deprecated usage of --id argument

@PRMerger20
Copy link
Collaborator

PRMerger20 commented Jul 7, 2020

@c-w : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger20 PRMerger20 requested a review from hansenms Jul 7, 2020
Copy link
Contributor

@hansenms hansenms left a comment

Thanks @c-w. Looks good.

@Mike-Ubezzi-MSFT
Copy link
Contributor

Mike-Ubezzi-MSFT commented Jul 8, 2020

Linking customer originating issue: #58000

@ktoliver ktoliver merged commit 6544f4e into MicrosoftDocs:master Jul 8, 2020
1 check passed
@c-w c-w deleted the patch-2 branch Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants