Remove jq in FHIR object id lookup instructions #58510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the FHIR documentation on how to look up Azure Active Directory object IDs using the Azure CLI depends on the external tool `jq` to extract specific items from JSON payloads returned by the CLI. However, the Azure CLI supports querying the JSON responses natively via [--query](https://docs.microsoft.com/en-us/cli/azure/query-azure-cli). As such, this change updates the documentation to use `--query` instead of `jq` which removes an external tool dependency and also makes the Azure CLI snippets work on Windows.
|
@c-w : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
hansenms
suggested changes
Jul 6, 2020
| @@ -25,7 +25,7 @@ $(Get-AzureADUser -Filter "UserPrincipalName eq 'myuser@consoso.com'").ObjectId | |||
| or you can use the Azure CLI: | |||
|
|
|||
| ```azurecli-interactive | |||
| az ad user show --upn-or-object-id myuser@consoso.com | jq -r .objectId | |||
| az ad user show --upn-or-object-id myuser@consoso.com --query objectId --out tsv | |||
There was a problem hiding this comment.
I think the latest versions of Azure CLI uses just --id instead of --upn-or-object-id, can you validate that works for you and correct at the same time?
There was a problem hiding this comment.
Yes, indeed, there's a deprecation warning with the --upn-or-object-id argument:
I updated this to --id in 4a7e688 which returns the same result as --upn-or-object-id but without the deprecation warning:
|
@c-w : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Linking customer originating issue: #58000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the FHIR documentation on how to look up Azure Active Directory object IDs using the Azure CLI depends on the external tool
jqto extract specific items from JSON payloads returned by the CLI.However, the Azure CLI supports querying the JSON responses natively via --query. As such, this change updates the documentation to use
--queryinstead ofjqwhich removes an external tool dependency and also makes the Azure CLI snippets work on Windows.