Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of <placeholder> in DNS names #64932

Merged
merged 1 commit into from Oct 23, 2020
Merged

Fix rendering of <placeholder> in DNS names #64932

merged 1 commit into from Oct 23, 2020

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Oct 23, 2020

The rendering of <ASE name>.appserviceenvironment.net and text using other placeholders that start with < and end with > characters is broken in the article "Create and use an Internal Load Balancer App Service Environment"..

The problem is due to the <ASE name> token getting interpreted by markdown as a custom HTML tag and therewith the text between the < and > characters doesn't show up (refer to screenshot below which highlights the problem areas in red underlines).

To display the text correctly, the < and > characters must be HTML-escaped (see for example how the "Use an App Service Environment" articles handles this). As such, this pull request fixes the rendering by replacing < with &lt; and > with &gt;.


Screenshot of broken rendering of <placeholders>

@PRMerger17
Copy link
Collaborator

@c-w : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver
Copy link
Contributor

Looks good/verified.

@ktoliver ktoliver merged commit b114a14 into MicrosoftDocs:master Oct 23, 2020
1 check passed
@c-w c-w deleted the patch-1 branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants