New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the "Configure autoscale rules" PowerShell script for Simplicity #6627

Merged
merged 5 commits into from Apr 9, 2018

Conversation

Projects
None yet
@pranoybej
Contributor

pranoybej commented Apr 3, 2018

Updated the "Configure autoscale rules" PowerShell Script for Simplicity.

@PRMerger16

This comment has been minimized.

Contributor

PRMerger16 commented Apr 3, 2018

@pranoybej : Thanks for your contribution! The author, @iainfoulds, has been notified to review your proposed change.

@iainfoulds

This comment has been minimized.

Contributor

iainfoulds commented Apr 3, 2018

Thanks for the contribution, @pranoybej . Those changes would make sense, and functionally doesn't change the commands.

Could you remove the additional content that has appeared on lines 225-272, that shouldn't all be there. We can then merge the PR.

#hold-off

Update tutorial-create-vmss.md
I have removed the unnecessary content from line no 225-272 as per your suggestion.
Thanks for pointing out.
@PRMerger20

This comment has been minimized.

Contributor

PRMerger20 commented Apr 4, 2018

@pranoybej : Thanks for your contribution! The author, @iainfoulds, has been notified to review your proposed change.

@iainfoulds

This comment has been minimized.

Contributor

iainfoulds commented Apr 5, 2018

Thanks for the updates, @pranoybej . There's still an incorrect change on line 224 that's removing content. We need to be really careful about any additional changes in PRs outside of the core lines that are being modified. The 'Files' tab shows a visual overview of what is being modified in a PR - https://github.com/MicrosoftDocs/azure-docs/pull/6627/files . If you can revert that change, we can merge this PR. Thanks.

@PRMerger15

This comment has been minimized.

Contributor

PRMerger15 commented Apr 6, 2018

@pranoybej : Thanks for your contribution! The author, @iainfoulds, has been notified to review your proposed change.

@pranoybej

This comment has been minimized.

Contributor

pranoybej commented Apr 6, 2018

Removed the extra from line 224...

@iainfoulds

This comment has been minimized.

Contributor

iainfoulds commented Apr 7, 2018

Thanks, @pranoybej . It looks like it's still removing the div on line 224, so I pulled over your commits into #6862 . Please update so that the file looks like https://github.com/MicrosoftDocs/azure-docs/pull/6862/files

Added the Missing div class on line 225.
Thank you so much for pointing out.
I hope now you can merge this.
@PRMerger19

This comment has been minimized.

Contributor

PRMerger19 commented Apr 8, 2018

@pranoybej : Thanks for your contribution! The author, @iainfoulds, has been notified to review your proposed change.

@iainfoulds

This comment has been minimized.

Contributor

iainfoulds commented Apr 9, 2018

#sign-off

@PRMerger10 PRMerger10 removed the do-not-merge label Apr 9, 2018

@v-shils v-shils merged commit b89d147 into MicrosoftDocs:master Apr 9, 2018

1 check passed

license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment