New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example use of private Azure Blob Storage #849

Merged
merged 3 commits into from Mar 15, 2017

Conversation

Projects
None yet
6 participants
@lwsrbrts
Contributor

lwsrbrts commented Feb 25, 2017

Provided an example of using private Azure Blob Storage for scripts/resource in a storage account that exists in the same subscription but a different resource group to store the scripts and other resources. Additionally described the rationale and method required for using listKeys instead of manually providing the storage account key to access resources stored in a private Azure Blob.

Provide example use of private Azure Blob Storage
Provided an example of using private Azure Blob Storage for scripts/resource in a storage account that exists in the same subscription but a different resource group to store the scripts and other resources. Additionally described the rationale and method required for using listKeys instead of manually providing the storage account key to access resources stored in a private Azure Blob.
@msftclas

This comment has been minimized.

msftclas commented Feb 25, 2017

@lwsrbrts,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftgits

This comment has been minimized.

msftgits commented Feb 27, 2017

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Feb 27, 2017

@msftgits msftgits reopened this Feb 27, 2017

@msftclas

This comment has been minimized.

msftclas commented Feb 27, 2017

@lwsrbrts,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@PRmerger

This comment has been minimized.

Collaborator

PRmerger commented Feb 27, 2017

@lwsrbrts : Thanks for your contribution to the Azure documentation! The author, @neilpeterson, has been notified to review your proposed change.

@neilpeterson

This comment has been minimized.

Contributor

neilpeterson commented Mar 2, 2017

@lwsrbrts thanks a bunch for this contribution, I really appreciate it. The scope of this set of articles is to provide a working end to end example, expose to basic template principles, while remaining as simple as possible. This unfortunately means that not every potential configuration will be covered.

That said, what you have provided here is important, and not currently documented. Would you be open to refactoring / simplifying the text, and updating the prerequisites section of the Custom Script extension docs?

https://docs.microsoft.com/en-us/azure/virtual-machines/virtual-machines-windows-extensions-customscript?toc=%2fazure%2fvirtual-machines%2fwindows%2ftoc.json#prerequisites

Thanks

@lwsrbrts

This comment has been minimized.

Contributor

lwsrbrts commented Mar 2, 2017

@neilpeterson I'll see what I can do with the text. The main issue is that by refactoring/simplifying the text, I'm removing important detail that may be obvious to people that have done it before but not so much to those who are brand new to template deployments of CSE from private Azure blob storage. The last thing I want when reading an article is to say to myself "Which Storage Account?" or "What Resource Group?" which is why my explanation might read quite verbose.

I'll try and simplify it sure and will look at the pre-reqs of the CSE doc but from a quick glance, it looks complete? Is there anything specific needed in the pre-reqs with the introduction of using private blob/container and listKeys?

@lwsrbrts

This comment has been minimized.

Contributor

lwsrbrts commented Mar 2, 2017

Hi @neilpeterson , Ive had another go with the text, let me know if that reads better.

4c9f394

@neilpeterson

This comment has been minimized.

Contributor

neilpeterson commented Mar 14, 2017

#sign-off

@jomolnar jomolnar merged commit 3204e03 into MicrosoftDocs:master Mar 15, 2017

@lwsrbrts lwsrbrts deleted the lwsrbrts:patch-1 branch Apr 4, 2017

rajumsys pushed a commit to rajumsys/azure-docs that referenced this pull request May 4, 2017

Merge pull request MicrosoftDocs#849 from cwatsonMSFT/TOCRes-AppServi…
…ce-11-11

Added resources section to app services toc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment