Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PIPNAME variable name more descriptive #9014

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
8 participants
@c-w
Copy link
Contributor

commented May 22, 2018

Without reading the code closely, it's not entirely obvious at first sight what PIPNAME represents. For example, a possible tokenization of that variable name can lead to the question "What is a PIP and why does it have a NAME?" Expanding the P abbreviation in the variable name to PUBLIC makes the name more immediate and therewith makes it easier to skim the code snippet.

Make PIPNAME variable name more descriptive
Without reading the code closely, it's not entirely obvious at first sight what `PIPNAME` represents. Expanding the `P` abbreviation in the variable name to `PUBLIC` makes the name more immediate and therewith makes it easier to skim the code snippet.
@PRMerger7

This comment has been minimized.

Copy link
Contributor

commented May 22, 2018

@c-w : Thanks for your contribution! The author, @neilpeterson, has been notified to review your proposed change.

@neilpeterson

This comment has been minimized.

Copy link
Contributor

commented May 22, 2018

@c-w thanks a bunch.

#sign-off

@ktoliver ktoliver merged commit 7fa9ed0 into MicrosoftDocs:master May 23, 2018

1 check passed

license/cla All CLA requirements met.

@c-w c-w deleted the c-w:patch-1 branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.