Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant az network public-ip list call #9048

Merged
merged 1 commit into from May 24, 2018
Merged

Remove redundant az network public-ip list call #9048

merged 1 commit into from May 24, 2018

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented May 23, 2018

The current version of the AKS ingress example makes two az network public-ip list calls to uniquely identify the public IP resource: one to grab the resource group of the public IP and one to grab the resource name of the public IP. These two calls can be replaced by a single call to fetch the resource ID of the public IP.

The current version of the AKS ingress example makes two `az network public-ip list` calls to uniquely identify the public IP resource: one to grab the resource group of the public IP and one to grab the resource name of the public IP. These two calls can be replaced by a single call to fetch the resource ID of the public IP.
@PRMerger10
Copy link
Collaborator

@PRMerger10 PRMerger10 commented May 23, 2018

@c-w : Thanks for your contribution! The author, @neilpeterson, has been notified to review your proposed change.

@neilpeterson
Copy link
Contributor

@neilpeterson neilpeterson commented May 24, 2018

@c-w thanks a bunch for this. Confirmed on my end, #sign-off .

@GitHubber17 GitHubber17 merged commit 5a59ee6 into MicrosoftDocs:master May 24, 2018
1 check passed
@c-w c-w deleted the patch-1 branch May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants