Remove redundant az network public-ip list call - #9048
Merged
Conversation
The current version of the AKS ingress example makes two `az network public-ip list` calls to uniquely identify the public IP resource: one to grab the resource group of the public IP and one to grab the resource name of the public IP. These two calls can be replaced by a single call to fetch the resource ID of the public IP.
Contributor
|
Clemens Wolff (@c-w) : Thanks for your contribution! The author, Neil Peterson (@neilpeterson), has been notified to review your proposed change. |
Contributor
|
Clemens Wolff (@c-w) thanks a bunch for this. Confirmed on my end, #sign-off . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of the AKS ingress example makes two
az network public-ip listcalls to uniquely identify the public IP resource: one to grab the resource group of the public IP and one to grab the resource name of the public IP. These two calls can be replaced by a single call to fetch the resource ID of the public IP.