Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Bot doesn't understand #sign-off when there are multiple reviewers #1611

Open
nschonni opened this issue Jun 11, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@nschonni
Copy link
Contributor

commented Jun 11, 2019

Is your feature request related to a problem? Please describe.
Previously, the bot did not pick up when there was multiple authors impacted for a PR. Because if that it would show an error message when the non-assigned author tried to sign off. Now that multiple reviewers are allowed, the bot still is rejecting #sign-off from authors that it doesn't see as the primary author (as with the previous behaviour). EX: on of the authors that the new bot assigned for review, but wouldn't accept the sign-off MicrosoftDocs/azure-docs#33065 (comment)

Describe the solution you'd like
The bot should allow any of the assigned Reviewers to #sign-off a PR.

Describe alternatives you've considered
Maybe removing the merge block isn't desired unless all/most of the authors have signed off. If that's the case, then maybe the message can be updated.

@ryanmajidi

This comment has been minimized.

Copy link
Collaborator

commented Jun 12, 2019

@meganbradley Can you please take a look at this issue?

@meganbradley

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@ryanmajidi @nschonni I'll get this fixed, thanks!

@meganbradley

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.