Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces listed are not version aware #222

Open
mairaw opened this issue Mar 12, 2018 · 10 comments
Open

Interfaces listed are not version aware #222

mairaw opened this issue Mar 12, 2018 · 10 comments
Assignees

Comments

@mairaw
Copy link
Collaborator

@mairaw mairaw commented Mar 12, 2018

Originally reported by @polewskm at dotnet/docs#2311

The documentation of Hash​Algorithm in the following target frameworks incorrectly mentions that it has an base interface of ICryptoTransform when this is not true:

If you browse the source for HashAlgorithm.cs you can find that the interface ICryptoTransform is only added for .NET Standard 2.0

I would attempt a PR to fix the documentation mistake but I do not know how to show different base interfaces for the combination of target frameworks.


From @rpetrusha: Thanks for opening this issue, @polewskm. The list of implemented interfaces is auto-generated using reflection. However, currently it does not take into account platform or version differences in interface implementation. We've opened an internal bug, #996154, to address this issue.


From @mairaw: @rpetrusha the internal bug referred here was about the list of interfaces not being complete, but I didn't see information about per version in that same bug. Perhaps you opened a different bug for this?

@dend are you aware of any bugs tracking this request?

@mairaw

This comment has been minimized.

Copy link
Collaborator Author

@mairaw mairaw commented May 8, 2018

Another case where the wrong interfaces are displayed @dend
dotnet/docs#5203

@mairaw mairaw changed the title Interface for Hash​Algorithm Interfaces listed are not version aware May 30, 2018
@mairaw

This comment has been minimized.

Copy link
Collaborator Author

@mairaw mairaw commented May 30, 2018

More issues are being reported for this:
dotnet/docs#5608
#226 (comment)

@dend do we have an issue logged?

@Powerhelmsman Powerhelmsman removed the triaged label Jun 26, 2018
@dend

This comment has been minimized.

Copy link
Contributor

@dend dend commented Jul 12, 2018

Closing this in favor of #226 - let's keep the conversation there.

@svick

This comment has been minimized.

Copy link

@svick svick commented Feb 26, 2020

Should this be reopened? As has been pointed out in this blog post, the issue is still not fixed. And the "duplicate" #226 was closed, because it was mostly about content, which doesn't belong in this repo. But that means it was not really a duplicate, because this issue is about infrastructure, which belongs here.

@mairaw mairaw removed the duplicate label Feb 26, 2020
@mairaw mairaw assigned mimisasouvanh and unassigned dend Feb 26, 2020
@mairaw

This comment has been minimized.

Copy link
Collaborator Author

@mairaw mairaw commented Feb 26, 2020

Yes, we should reopen

@mairaw mairaw reopened this Feb 26, 2020
@mairaw

This comment has been minimized.

Copy link
Collaborator Author

@mairaw mairaw commented Feb 26, 2020

#log-suggestion

@orcabot

This comment has been minimized.

Copy link
Collaborator

@orcabot orcabot commented Feb 26, 2020

🚀 ATTENTION: Internal request logged.

@mairaw mairaw added bug and removed enhancement labels Feb 26, 2020
@jnm2

This comment has been minimized.

Copy link

@jnm2 jnm2 commented Feb 26, 2020

I have run into this several times in the last two weeks.

@mairaw

This comment has been minimized.

Copy link
Collaborator Author

@mairaw mairaw commented Feb 27, 2020

This looks like an mdoc bug @joelmartinez given the XML doesn't show alternative signatures.

@joelmartinez

This comment has been minimized.

Copy link

@joelmartinez joelmartinez commented Feb 27, 2020

@mairaw there is working scheduled to begin very soon that will address this very issue :D

@PRMerger9 PRMerger9 added the Pri3 label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.