New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Solus] Live Share extension fails activation, errors about /usr/local/bin missing when pasting browser integration command #215
Comments
|
@tristan957 Thanks for reporting the issue. Solus is not a distro of Linux we've tested since there's no official VS Code package for it. (In fact, wasn't even aware there was a VS Code package for it at all.) The command that has errored enables browser integration so the errors you are seeing means setup has failed. You will still be able to manually join without it, however. You can also try creating the /usr/local/bin folder, run the command, and see if browser integration works. This is the only distro I've ever heard of that does not have that folder, so it's a bit odd. This seems to indicate creating it should work, but your results may vary. |
|
Thanks for the link to the thread. It seems like you're making an assumption that /use/local/bin exists. Is it possible for you to check if it exists at runtime and of not create the directory within the script? This is a completely different approach, but is it possible that within the VSCode folder there could be a /bin folder like ~/.vscode/bin? I don't really like the fact that Live Share is installing in my root directory in the first place. Yarn, NPM, Pip, and Cargo all install in my home directory and then I can append to PATH to access these executables. |
|
@tristan957 A desktop shortcut needs to be placed in the right location in order for the browser to pick it up and extensions do not have installers or package mangers built in. Live Share itself is not placed that location functions completely without this being present. It's purely to facilitate browser integration. As I mentioned above, you can skip this step and use manual joins instead if you'd prefer. We could investigate an alternate location as a feature request. |
|
I guess I'm trying to understand the browser integration you are referring to. I'd like to explain how Atom's Teletype approaches browser integration, and maybe you can confirm that this is what you're talking about. Teletype is an extension very similar to Live Share. When I choose to share my workspace I am given a link along the lines of |
|
@tristan957 Live Share is a multi-tool, multi-OS feature. We currently support VS Code on Windows, Mac, and Linux and Visual Studio on Windows. Over time we expect to support at least VS for Mac if not others. Keep in mind the service side of Live Share is used by all tools and all operating systems. As a result, the invitation page cannot use a tool specific protocol. It uses a vsls:// protocol instead. Further, the landing page actually automatically detects whether or not you have a tool with the Live Share extension installed based on whether or not this protocol is available. You will get install instructions if not and it will automatically launch if so. On Windows, you can then opt to use VS Code or VS as you see fit. Mac will be similar over time. |
|
@tristan957 I actually installed Solus and it looks like the VS Code instance I was able to install is a bit non-standard since even ignoring the error you reported here, the extension fails to initialize complaining about experimental APIs missing. (You can see this in Help > Toggle Developer Tools) It appears to be an issue with the actual Solus VS Code package rather than the Live Share extension/ Are you seeing the Share and Sign in buttons in the status bar? How did you install VS Code? |
|
I am not seeing those buttons. I installed it through my package manager. |
^^^ from console |
|
@tristan957 Okay, so independently of this @avanderhoorn logged #262 which is the exact same problem as this second issue. Whoever is creating the VS Code distribution for Solus is not including the entirety of the product.json file that we see in other instances. Specifically, this is missing: In fact, this probably would result in problems with Node debugging as well. Live share is just one of the three. You can see the file once VS Code is installed at If you add the above into that file, Live Share will start. HOWEVER, sign in will fail due to what is likely this issue #212 which apparently is a .NET Core issue. |
|
@Chuxel I am busy for the rest of the night, but I'll review this with my package maintainer and see if this is the fix we are looking for. I'll keep you posted. |
|
@tristan957 Sounds good. We raised a general "quesiton" issue on it since we have seen this error in telemetry and may be happening with other distos but we just haven't heard about. As I said, things will still fail due to a .NET Core issue with certain libcurl versions. Gentoo and Solus must have a recent enough version to cause the problem. You can see info on that in #212. |
|
@tristan957 I believe we have now resolved this particular issue. We now use ~/.local/share if it is found instead of /usr/local/bin. #212 we now have a clearer picture as to what is going on - it looks like a recompiled version of curl is required. We also separated out the Code OSS issue into #262. As a result, I'm thinking we can close this one in favor of the other two. Thanks for raising it!! Let us know if this particular aspect of the problem persists. |
|
Perfect. Thank you for your assistance |
Product and Version [VS/VSCode]: 1.22.2
OS Version [macOS/Windows]: Solus (Linux)
Live Share Extension Version: 0.2.399
Target Platform or Language [e.g. Node.js]: uhhh..
Steps to Reproduce / Scenario:
logs.zip
I am receiving the following errors after installation and pasting the command in my terminal.
Can they be disregarded?
The text was updated successfully, but these errors were encountered: