Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update restore-statements-transact-sql.md #3353

Merged
merged 2 commits into from Oct 28, 2019

Conversation

@amtwo
Copy link
Contributor

amtwo commented Oct 19, 2019

Statement about clearing cache implies the entire cache gets cleared, but this is not accurate. The cache is only partially cleared. Only the database being replaced by the restore has it's cache cleared.

Statement about clearing cache implies the entire cache gets cleared, but this is not accurate. The cache is only *partially* cleared. Only the database being replaced by the restore has it's cache cleared.
@PRMerger13

This comment has been minimized.

Copy link
Contributor

PRMerger13 commented Oct 19, 2019

@amtwo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MikeRayMSFT

This comment has been minimized.

Copy link
Contributor

MikeRayMSFT commented Oct 25, 2019

@bluefooted - can you review?

@bluefooted

This comment has been minimized.

Copy link
Contributor

bluefooted commented Oct 25, 2019

Thanks for the heads-up! @amtwo is correct in that only the plan cache for the database is cleared, but the entire paragraph needs reworking. We don't actually throw that error when you restore a database since we're not clearing the entire plan cache. I think we should remove everything except the first two sentences. @MikeRayMSFT can we do that directly in this PR or should we accept this one and then file a new PR in the private repo?

Additional change suggested by @bluefooted
@PRMerger19

This comment has been minimized.

Copy link
Contributor

PRMerger19 commented Oct 26, 2019

@amtwo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@amtwo

This comment has been minimized.

Copy link
Contributor Author

amtwo commented Oct 26, 2019

I pushed the additional change @bluefooted suggested to remove those additional sentences

@bluefooted

This comment has been minimized.

Copy link
Contributor

bluefooted commented Oct 28, 2019

Looks good to me @amtwo thank you! @MikeRayMSFT this is good to go.

@bluefooted

This comment has been minimized.

Copy link
Contributor

bluefooted commented Oct 28, 2019

#sign-off

@PRMerger15

This comment has been minimized.

Copy link
Contributor

PRMerger15 commented Oct 28, 2019

@bluefooted: I'm sorry - only the author of this article, @MikeRayMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@jborsecnik

This comment has been minimized.

Copy link
Contributor

jborsecnik commented Oct 28, 2019

@MikeRayMSFT, ok to merge?

@ktoliver ktoliver merged commit 73ee0b4 into MicrosoftDocs:live Oct 28, 2019
1 check passed
1 check passed
license/cla All CLA requirements met.
@amtwo amtwo deleted the amtwo:patch-4 branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.