Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions using iframes or directly referencing localhost server content in webviews do not work in the browser-based editor #11

Open
Chuxel opened this issue Oct 28, 2019 · 1 comment

Comments

@Chuxel
Copy link
Collaborator

@Chuxel Chuxel commented Oct 28, 2019

While the VS Code extension guide covers changes to webview scenarios like the use of asWebviewUri to enable VSO's browser-based editor, there appears to be an issue that prevents webview content from interacting with forwarded localhost servers (via asExternalUri) - including in an iframe.

Steps to reproduce:

  1. Create a VSOe
  2. Add the attached project into it: webview 5.zip
  3. Connect with VSO's browser-based editor (if you have not already)
  4. yarn install
  5. F5
  6. After the extension activates, run WebView Example: WebView Demo

Expected: Webview appears with "Hello remote world!" in an iframe
Actual: iframe redirects to login, but does not proceed further - no indication as to why

Interestingly if you run WebView Example: Browser Demo, let the login succeed, and then run the Webvew Demo command again, it works. So it's clearly related to the login specifically.

This also seems to be preventing XHR or other requests from working from webview content from working as well.

@nikmd23 nikmd23 added the bug label Oct 28, 2019
@Chuxel

This comment has been minimized.

Copy link
Collaborator Author

@Chuxel Chuxel commented Nov 4, 2019

Related to #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.