Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the documentation for nuget pack -action #6215

Open
wants to merge 2 commits into
base: master
from

Conversation

@koskila
Copy link
Contributor

koskila commented Oct 31, 2019

I was really struggling to get the nuget package versioning to work as I wanted - After a lot of trial and error, I got the process to work, and used my experiences to try and make the documentation a bit more comprehensive.

Hope it's useful!

@chasewilson chasewilson self-assigned this Nov 4, 2019
packTimezone: utc
```

For **byEnvVar**, the version will be set as whatever environment variable, e.g. `MyVersion` (no **$**, just the environment variable name), you provide. Make sure the environment variable is set to a proper SemVer e.g. `1.2.3` or `1.2.3-beta1`. If you select this option, you also need to set the environment variable, like in the example below.

This comment has been minimized.

Copy link
@chasewilson

chasewilson Nov 4, 2019

Collaborator

Would you be able to update to match the env vars in the text and the example?

@chasewilson

This comment has been minimized.

Copy link
Collaborator

chasewilson commented Nov 4, 2019

@koskila This is great work and the contribution is greatly appreciated! There's just one small update but I'll keep an eye on it and merge it ASAP :)

@PRMerger9 PRMerger9 requested a review from chasewilson Nov 6, 2019
@PRMerger9

This comment has been minimized.

Copy link
Contributor

PRMerger9 commented Nov 6, 2019

@koskila : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.