Skip to content

Conversation

@get-itips
Copy link
Contributor

@ghost
Copy link

ghost commented Jun 10, 2019

Example 3 needs to have the comments/descriptive text moved out of the example (the idea being that the cmdlet text is something you could copy/paste).

Also, what about previous versions of Hyper-V where XML is correct?

@get-itips
Copy link
Contributor Author

@tseward thanks for your review.
Actually, tbh, I would completely remove example 3, but it was present before my PR, I tried to fix it now.

About XML, as that was valid for previous versions, and this article is for 2016, which uses vcmx, that would be covered with different versions of the same article (Selecting the required version of your O.S. at the left panel)
Thank you again.

@ghost
Copy link

ghost commented Jun 10, 2019

@get-itips I'd remove example 3, then :)

I'm not sure how the versioning is done in this repo (with SharePoint, we manually mark it as such) but if that will continue to work, sounds good.

@dariomws
Copy link
Contributor

I agree with both. Let's remove example 3.

@get-itips
Copy link
Contributor Author

done

@AndreaBarr AndreaBarr merged commit f459055 into MicrosoftDocs:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants