Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

savannah: mc's built-in samba library is out of date #1

Closed
mc-butler opened this issue Dec 24, 2008 · 34 comments
Closed

savannah: mc's built-in samba library is out of date #1

mc-butler opened this issue Dec 24, 2008 · 34 comments
Assignees
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress ver: 4.6.1 Reproducible in version 4.6.1
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1
Reporter spock
Mentions info@….net (@metux)
Keywords samba

Original: http://savannah.gnu.org/bugs/?5142

Submitted by:Michał Januszewski <spock>Submitted on:08 Sep 2003 14:20:05
Category:VFSSeverity:3 - Normal
Status:NonePrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:4.6.0Operating System:All

Original submission:

The mc's built-in samba library which is used to access data across
smb links is taken from an old samba version. This can cause 
problems since things change as time goes on. For example - current 
samba version supports something like: "interface = eth1" in 
smb.conf, the version included in mc does not. This leads to calling
 gethostname("eth1") 3 times at startup (on my box). Recently I have
 had some problems with the DNS servers I use. I had to wait 3 
minutes (!) before mc started because it tried to resolve "eth1" (2 
times ) and "ETH1" (which of course wasn't possible because of the 
DNS server failure).

I have created this patch for mc:
http://www.spock.mga.com.pl/public/gentoo/mc-4.6.0-samba.patch.bz2
(sorry to put it on an external site but since it's almost 600kb, I 
didn't want to upload it here). It updates mc's samba libraries to 
2.2.8a. By doing so it automatically fixes another problem - namely,
 with current vesions of libcap an error (redefinition of struct 
statfs) occurs while building mc.

Comment 1 by Pavel Roskin <proski> at Mon 05 Dec 2005 02:06:15 AM UTC:

We'll have this problem as long as mc uses Samba configuration 
files. Every time Samba changes the format of its configuration 
files, mc will have to be upgraded (not just recompiled).

I see two solutions:

1) Use libsmbclient. This way, upgrading Samba will upgrade the 
client library, and mc will recognize new configuration.

2) Don't use Samba configuration files in mc. Use a separate 
configuration file or store all configuration in ~/.mc/ini

I would prefer that we at least try to use libsmbclient, and if it 
doesn't work, let's report it to Samba maintainers. This way, 
libsmbclient will be ready for mc some day.

Comment 2 by Sorin Sbarnea <sorin> at Wed 30 Jul 2008 05:56:11 PM UTC:

I wonder why this wasn't solved in 5 years. It's quite common and 
makes mc unusable. The average timeout is ~1 minute.

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 25, 2008 at 10:51 UTC (comment 1)

  • Description edited

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 25, 2008 at 20:36 UTC (comment 2)

Related ticket #40

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 26, 2008 at 10:49 UTC (comment 3)

Related ticket #88

@mc-butler
Copy link
Author

Changed by metux (@metux) on Dec 26, 2008 at 21:36 UTC (comment 4)

My vote is to kick off the bundled lib completely and
expect it installed on the system.

@mc-butler
Copy link
Author

Changed by winnie (@winnieXY) on Jan 2, 2009 at 17:33 UTC

  • Blocking set to #88

@mc-butler
Copy link
Author

Changed by winnie (@winnieXY) on Jan 2, 2009 at 17:34 UTC

@mc-butler
Copy link
Author

Changed by styx (@styx) on Apr 20, 2009 at 9:08 UTC (comment 7)

  • Version pre4.6.1 deleted
  • Milestone set to 4.7

@mc-butler
Copy link
Author

Changed by styx (@styx) on Apr 30, 2009 at 13:42 UTC

libsmbclient.h with doxygen doc

@mc-butler
Copy link
Author

Changed by styx (@styx) on May 18, 2009 at 12:03 UTC (comment 8)

  • Milestone changed from 4.7 to future releases

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 26, 2009 at 23:00 UTC

(In #273) Need to review internal SAMBA stuff (may me, will replaced by dynamic linking with libsmbclient.so). Then we need to review this ticket.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 26, 2009 at 23:22 UTC (comment 10)

  • Milestone changed from future releases to VFS Standardisation

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 25, 2009 at 13:26 UTC

(In #273) #1619

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 15, 2010 at 11:27 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 5, 2010 at 13:56 UTC (comment 13)

  • Version set to 4.6.1
  • Component changed from mc-core to mc-vfs
  • Severity set to no branch

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 25, 2011 at 12:53 UTC

@mc-butler
Copy link
Author

Changed by eventsiaarhus (info@…-i-aarhus.dk) on May 14, 2012 at 13:58 UTC (comment 15)

  • Branch state set to no branch

I cant download this anymore http://www.spock.mga.com.pl/public/gentoo/mc-4.6.0-samba.patch.bz2 ?? Where can i get it ?

David.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Feb 20, 2013 at 10:52 UTC (comment 16)

  • Owner set to slavazanko
  • Status changed from new to accepted

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jun 2, 2013 at 12:41 UTC (comment 17)

  • Keywords set to samba
  • Branch state changed from no branch to on rework

Created branch: 1_smbfs

Initial [7a7b4c4c9011493ac88ea772676739b106980cbb]

Review, please

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jan 11, 2014 at 14:51 UTC (comment 18)

  • Reporter changed from slavazanko to spock
  • Description edited

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 18, 2015 at 18:27 UTC (comment 19)

  • Milestone changed from 4.8 to Future Releases

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 2, 2018 at 4:04 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 17, 2019 at 4:01 UTC

@mc-butler
Copy link
Author

Changed by metux (@metux) on Aug 8, 2019 at 20:30 UTC (comment 22)

  • Cc set to info@….net

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 28, 2020 at 17:56 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 7, 2021 at 18:25 UTC (comment 24)

Ticket #4288 has been marked as a duplicate of this ticket.

@mc-butler
Copy link
Author

Changed by birdie (aros@….com) on Sep 8, 2021 at 1:02 UTC (comment 25)

What about adding a warning that only SMB1.0 protocol is supported? This is a very fast fix for the obviously broken feature.

That will stop people from scratching their heads trying to understand why it doesn't work, e.g.

https://unix.stackexchange.com/questions/668049/how-do-i-connect-to-a-smb-samba-share-using-midnight-commander

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 8, 2021 at 7:48 UTC (comment 26)

I'd rather remove the code completely - SMB support has already been disabled in Debian for this very reason, but Fedora people have so far ignored our advice to do the same.

It's been 13 years since it has been half-broken. If somebody needs it, they should finish the branch by Slava... it's not too much work for someone who has time (see sftp VFS).

Andrew, what do you think?

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 8, 2021 at 18:34 UTC (comment 26.27)

Replying to zaytsev:

I'd rather remove the code completely

I agree.

@mc-butler
Copy link
Author

Changed by birdie (aros@….com) on Sep 9, 2021 at 11:34 UTC (comment 28)

Where's the like button?

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 11, 2021 at 6:29 UTC (comment 29)

  • Milestone changed from Future Releases to 4.8.28
  • Owner changed from slavazanko to andrew_b
  • Branch state changed from on rework to on review

Branch: 1_smbfs_remove
Initial changeset: [781ad4c53c5d0752108257813736bf054f60bc60]

@mc-butler mc-butler marked this as a duplicate of #4288 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress ver: 4.6.1 Reproducible in version 4.6.1
Development

No branches or pull requests

2 participants