[PATCH] (git) Fixup homepage url

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/137
Reporter	Enrico.Weigelt@….local, metux IT service <weigelt@….de>
Keywords	committed-master, committed-mc-4.6, vote-slavazanko, vote-winnie

This patch fixes the homepage url to http://www.midnight-commander.org/ in various locations

Commited to master and mc-4.6

Note

Original attachments:

• git08123111-new-homepage.diff (raw) by on Jan 4, 2009 at 0:46 UTC

[mc-butler]

Changed by mc-butler (@mc-butler) on Jan 4, 2009 at 0:46 UTC

• Attachment git08123111-new-homepage.diff (raw) added
• Id set to 137

This message has 1 attachment(s)

[mc-butler]

Changed by metux (@metux) on Jan 4, 2009 at 1:41 UTC (comment 2)

• Version 4.6.1 deleted
• Description edited
• Milestone set to 4.6.2
• Summary changed from [PATCH] git: Fixup homepage url to [PATCH] (git) Fixup homepage url
• Priority changed from major to critical

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 4, 2009 at 11:11 UTC (comment 3)

• Type changed from defect to task

I agree with idea in patch. Homepage need to change in any case.

+1.

[mc-butler]

Changed by winnie (@winnieXY) on Jan 4, 2009 at 15:59 UTC (comment 4)

• Status changed from new to assigned
• Owner set to metux

Tested on master and works fine..
As far as I can see this were all places where the url has to be changed.. Therefore:

+1

@enrico? I've assigned you to the ticket. I guess this is what you wanted? :) Next time simply accept it ;-)

[mc-butler]

Changed by Enrico Weigelt on Jan 4, 2009 at 21:27 UTC

:)

I'm not sure if that's the right way - shouldnt the ticket be
assigned to someone with commit authority ?

cu

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 5, 2009 at 9:31 UTC (comment 6)

Reassing of ticket mean other developer (or visitor) need to rework patch, give more info in comment, continue working with ticket, etc... After this complete, ticket reassigning back. Or not reassign back, in this case assigner (if developer) need to apply patch (create branch).

About named of branches... I think, simply to 'Summary' of ticket... or simular to patch name...

For example:
git-branch 'fixup-homepage-url' # all letters in lower case
or
git-branch 'git08123111-new-homepage'

P.S. This additional to workflow in mail list... details appear in the process of works:)

[mc-butler]

Changed by metux (@metux) on Jan 6, 2009 at 19:00 UTC (comment 7)

• Keywords set to review

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 9, 2009 at 1:02 UTC (comment 8)

Duplicate #138

[mc-butler]

Changed by winnie (@winnieXY) on Jan 9, 2009 at 10:30 UTC (comment 9)

• Keywords changed from review to review, vote-slavazanko, vote-winnie

I add vote-slavazanko and vote-winnie as we already voted in the text for this patch.

@metux: If you want I'll help you this evening in merging this patch now into the mc-4.6 branch okay?

[mc-butler]

Changed by winnie (@winnieXY) on Jan 9, 2009 at 10:36 UTC (comment 10)

• Keywords changed from review, vote-slavazanko, vote-winnie to review, vote-slavazanko, vote-winnie, approved

Forgot to add approved keyword

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 9, 2009 at 12:07 UTC (comment 11)

I add vote-slavazanko and vote-winnie as we already voted in the text for this patch.

agree.

[mc-butler]

Changed by metux (@metux) on Jan 9, 2009 at 17:17 UTC (comment 12)

• Keywords changed from review, vote-slavazanko, vote-winnie, approved to vote-slavazanko, vote-winnie, approved

Removed the review keyword, since it's now approved.

BTW: should we introduce news keywords for patches that have been applied ?

[mc-butler]

Changed by winnie (@winnieXY) on Jan 11, 2009 at 9:39 UTC (comment 13)

no.. simply resolve the ticket as fixed. I'll close this ticket then later (as only Ticket_admin is allowed to do this currently.. I think I'll change this behaviour in the future).

[mc-butler]

Changed by metux (@metux) on Jan 11, 2009 at 21:04 UTC (comment 14)

• Keywords changed from vote-slavazanko, vote-winnie, approved to committed-master, committed-mc-4.6, vote-slavazanko, vote-winnie
• Description edited

[mc-butler]

Changed by winnie (@winnieXY) on Jan 13, 2009 at 21:50 UTC (comment 15)

• Status changed from assigned to testing
• Resolution set to fixed

[mc-butler]

Changed by winnie (@winnieXY) on Jan 13, 2009 at 21:50 UTC (comment 16)

• Status changed from testing to closed

[mc-butler]

Changed by zaytsev (@zyv) on Feb 20, 2025 at 15:39 UTC (comment 17)

Ticket #138 has been marked as a duplicate of this ticket.