Erlang syntax file

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1408
Reporter	baryluk (witold.baryluk@….com)
Keywords	commited-master

Hi, i created Erlang syntax file about 2 weeks ago, and was testing it since then. It looks quite good (but few minor syntax forms are not implemented yet, see comments in file). So considering that is is far better than nothing and actually it works, I will ask for inclusion in master branch.

Most actuall version:

http://smp.if.uj.edu.pl/~baryluk/erlang.syntax

Syntax entries:

file ..\*\\.erl$ Erlang\sProgram  ^(-module\\(|#!.*escript)
include erlang.syntax

file ..\*\\.hrl$ Erlang\sHeader ^-record\(
include erlang.syntax

Merged as [d3f1b16]
Take 2 merged as [0cfde89]

Note

Original attachments:

• erlang.syntax (raw) by baryluk (witold.baryluk@….com) on Jul 15, 2009 at 13:17 UTC
• erlang-samples.tar.gz (raw) by baryluk (witold.baryluk@….com) on Aug 2, 2009 at 14:17 UTC
• erlang.2.syntax (raw) by baryluk (witold.baryluk@….com) on Aug 2, 2009 at 14:26 UTC

[mc-butler]

Changed by baryluk (witold.baryluk@….com) on Jul 15, 2009 at 13:17 UTC

• Attachment erlang.syntax (raw) added

[mc-butler]

Changed by baryluk (witold.baryluk@….com) on Jul 15, 2009 at 13:19 UTC (comment 1)

• Version changed from 4.6.2 to master

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 15, 2009 at 14:10 UTC (comment 2)

• Milestone changed from 4.7 to 4.7.0-pre2

patch simply: no reason for wait 4.7 release.

4.7.0-pre1 now frozen for new features - just fixing critical bugs.

This for 4.7.0-pre2.

[mc-butler]

Changed by styx (@styx) on Jul 15, 2009 at 17:10 UTC (comment 3)

• Votes set to vote-styx
• Owner set to styx
• Status changed from new to accepted

Branch: 1408_erlang_syn_hl
Changeset: [05d729b22f58de1af74359612958355e74af019d]

[mc-butler]

Changed by styx (@styx) on Jul 15, 2009 at 17:34 UTC (comment 4)

• Severity changed from no branch to on review

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jul 16, 2009 at 5:54 UTC (comment 5)

• Votes changed from vote-styx to styx angel_il

but wait before pre1 released

[mc-butler]

Changed by styx (@styx) on Jul 16, 2009 at 18:56 UTC (comment 6)

• Severity changed from on review to approved

[mc-butler]

Changed by styx (@styx) on Aug 1, 2009 at 6:36 UTC (comment 7)

• Status changed from accepted to testing
• Resolution set to fixed
• Severity changed from approved to merged

[mc-butler]

Changed by styx (@styx) on Aug 1, 2009 at 6:36 UTC (comment 8)

• Status changed from testing to closed

[mc-butler]

Changed by slyfox (@trofi) on Aug 2, 2009 at 8:12 UTC (comment 9)

• Description edited

[mc-butler]

Changed by slyfox (@trofi) on Aug 2, 2009 at 8:12 UTC (comment 10)

• Description edited

[mc-butler]

Changed by baryluk (witold.baryluk@….com) on Aug 2, 2009 at 13:05 UTC (comment 11)

I think, there is missing backslash (after record).

It sould be:

file ..\*\\.erl$ Erlang\sProgram  ^(-module\\(|#!.*escript)
include erlang.syntax

file ..\*\\.hrl$ Erlang\sHeader ^-record\\(
include erlang.syntax

[mc-butler]

Changed by slyfox (@trofi) on Aug 2, 2009 at 13:41 UTC (comment 11.12)

• Resolution fixed deleted
• Status changed from closed to reopened

Replying to baryluk:

I think, there is missing backslash (after record).

It sould be:

file ..\*\\.erl$ Erlang\sProgram  ^(-module\\(|#!.*escript)
include erlang.syntax

file ..\*\\.hrl$ Erlang\sHeader ^-record\\(
include erlang.syntax

Can You provide some erlang samples in tarball and patch on top of current git master?

[mc-butler]

Changed by baryluk (witold.baryluk@….com) on Aug 2, 2009 at 14:05 UTC (comment 13)

This are pretty hard samples (big and lots of syntax used).

Problems notices:

xmerl_sax_parser_utf8.erl starting at line 1294, "\"" sequence (escaped " in string).
xmerl_scan.erl starting at line 2305, also "\"" sequence

I have fix prepared (copied from C and D syntax hightling files), but need to look at erlang specification to be sure which escape sequences are allowed.

[mc-butler]

Changed by baryluk (witold.baryluk@….com) on Aug 2, 2009 at 14:17 UTC

• Attachment erlang-samples.tar.gz (raw) added

[mc-butler]

Changed by baryluk (witold.baryluk@….com) on Aug 2, 2009 at 14:19 UTC (comment 14)

Ok, new version attached as erlang.2.syntax.
Based on http://www.erlang.org/doc/reference_manual/data_types.html#2.14 and D syntax file.

file escape.erl in erlang-samples.tar.gz shows now that it works. xmerl_* samples also now works properly.

[mc-butler]

Changed by baryluk (witold.baryluk@….com) on Aug 2, 2009 at 14:26 UTC

• Attachment erlang.2.syntax (raw) added

New erlang syntax file (with escape sequenced in strings and atom, few dict:* functions added)

[mc-butler]

Changed by slyfox (@trofi) on Aug 2, 2009 at 14:49 UTC (comment 14.15)

• Severity changed from merged to on review
• Votes styx angel_il deleted

Replying to baryluk:

Ok, new version attached as erlang.2.syntax.
Based on http://www.erlang.org/doc/reference_manual/data_types.html#2.14 and D syntax file.

file escape.erl in erlang-samples.tar.gz shows now that it works. xmerl_* samples also now works properly.

Thanks!
Patch is available as [7f9f5d41972610c5f64656f40ff6c3df5f75ec29]
it sits in branch:1408_erlang_fixes.

Please review.

[mc-butler]

Changed by iNode (@iNode) on Aug 2, 2009 at 14:57 UTC (comment 16)

• Votes set to iNode

[mc-butler]

Changed by slyfox (@trofi) on Aug 2, 2009 at 16:43 UTC (comment 17)

• Owner changed from styx to slyfox
• Votes changed from iNode to iNode slyfox approved
• Status changed from reopened to accepted

[mc-butler]

Changed by slyfox (@trofi) on Aug 2, 2009 at 16:51 UTC (comment 18)

• Severity changed from on review to merged
• Status changed from accepted to testing
• Keywords set to commited-master
• Resolution set to fixed
• Description edited

[mc-butler]

Changed by styx (@styx) on Aug 2, 2009 at 18:30 UTC (comment 19)

• Status changed from testing to closed
• Votes changed from iNode slyfox approved to iNode slyfox

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 2, 2009 at 20:55 UTC (comment 20)

Merged: [d3f1b16]