Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel scrollbar #1483

Open
mc-butler opened this issue Aug 6, 2009 · 23 comments
Open

Panel scrollbar #1483

mc-butler opened this issue Aug 6, 2009 · 23 comments
Assignees
@slavaz
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.7.0-pre1 Reproducible in version 4.7.0-pre1
Milestone
Future Releases

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1483
Reporter dborca (dborca@….com)
Mentions dborca@….com, gotar@….pl, ales.janda@….cz (@kybl)

The following patch adds a primitive scroll indicator to the file panels. It will display only on the active panel, and only if necessary.

Attached patch (against 4.7.0-pre1) does this.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by dborca (dborca@….com) on Aug 6, 2009 at 21:52 UTC

@mc-butler
Copy link
Author

Changed by dborca (dborca@….com) on Aug 6, 2009 at 23:57 UTC (comment 1)

  • Cc set to dborca@….com

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 7, 2009 at 4:21 UTC (comment 2)

The scrollbar should be implemented as widget to use it where it need.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Aug 7, 2009 at 5:28 UTC

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Aug 7, 2009 at 7:04 UTC (comment 3)

  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

@mc-butler
Copy link
Author

Changed by dborca (dborca@….com) on Aug 7, 2009 at 15:15 UTC (comment 2.4)

Replying to andrew_b:

The scrollbar should be implemented as widget to use it where it need.

And where would be that, besides panels? WListboxes already have their own scrollbar.

o·ver·do

  1. o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does

v.tr.
1.

  1. To do, use, or stress to excess; carry (something) too far.
  2. To exaggerate.
  3. To wear out the strength of; overtax.
  4. To cook (food) too long.

v.intr.
To do too much; go to extremes.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 7, 2009 at 17:22 UTC (comment 4.5)

Replying to dborca:

Replying to andrew_b:

The scrollbar should be implemented as widget to use it where it need.

And where would be that, besides panels?

Do you need it right now?

WListboxes already have their own scrollbar.

Yes. This scrollbar should be reinplemented to WScrollbar widget to use it in panels, listboxes, etc.

o·ver·do

  1. o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does

v.tr.
1.

  1. To do, use, or stress to excess; carry (something) too far.
  2. To exaggerate.
  3. To wear out the strength of; overtax.
  4. To cook (food) too long.

v.intr.
To do too much; go to extremes.

What is it?

@mc-butler
Copy link
Author

Changed by dborca (dborca@….com) on Aug 7, 2009 at 19:50 UTC (comment 5.6)

Replying to andrew_b:

Replying to dborca:

Replying to andrew_b:

The scrollbar should be implemented as widget to use it where it need.

And where would be that, besides panels?

Do you need it right now?

Yes. No. I need it since 1.5 years ago. :) I also have it since 1.5 years ago.
There are various patches for this since the beginning of time. Just look at Debian.

WListboxes already have their own scrollbar.

Yes. This scrollbar should be reinplemented to WScrollbar widget to use it in panels, listboxes, etc.

This is called overdoing things (hunting mosquitoes with a Howitzer). I'd rather save those few extra cycles of CPU for anything better (or memory; or disk space). I'd rather have it the simple way than not having it at all. Ok, so I have it already, sorry for sharing it.

A simple thing that makes life easier, but won't, because it is not implemented The Right Way (tm). But The Right Way (tm) takes too much time, so it won't get implemented in the near future.

o·ver·do

  1. o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does

v.tr.
1.

  1. To do, use, or stress to excess; carry (something) too far.
  2. To exaggerate.
  3. To wear out the strength of; overtax.
  4. To cook (food) too long.

v.intr.
To do too much; go to extremes.

What is it?

Sorry, too much coffee :)

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 22, 2009 at 10:45 UTC (comment 7)

  • Owner set to slavazanko
  • Status changed from new to accepted

crutch
backstay

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 22, 2009 at 10:51 UTC (comment 8)

  • Milestone changed from 4.7.0-pre3 to 4.7.0-pre4

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 22, 2009 at 14:52 UTC (comment 9)

  • Severity changed from no branch to on review
  • Milestone changed from 4.7.0-pre4 to 4.7.0-pre3

created branch 1483_panel_scrollbar (parent: master)

initial [f8c908bbe94e712f30246fa8611b454261870082]

Control drawing of scrollbar via skin-file: [4761bcb42fcb1a067344e50d47bc8974a31af784]

TODO: drawing scrollbar in any position of widget, but now I don't see sence to complete this work.

review, please.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 23, 2009 at 6:27 UTC (comment 10)

  • Severity changed from on review to on rework

Okay, as we discuss in jabber room, need to rework scrollbar. This must be fully-functional widget (with reaction on mouse scroll or click) and need to add srollbar (as widget) into LIST, PANEL etc. elements (not in all widgets).

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 23, 2009 at 12:25 UTC (comment 11)

  • Milestone changed from 4.7.0-pre3 to 4.7.0-pre4

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 13:59 UTC (comment 12)

  • Severity changed from on rework to on review

Branch rebased.
New commits history:

  • [5e801d1891e8e7c1b57523e56902bfb4c9467d19]: Move all widgets-related files into subdir
  • [e00d9dc4dd45b2e39103aae54bfe4be324f56c04]: move move widget_t declaration into widget-struct.h file
  • [8dcc09c9f8f84f58f12a72e555566cdfe462689f]: Change type of widget callbals.
  • [a59f5df23356455561ca22547079d2d375443f95]: fix commit: Checked dialogs return value in all files.
  • [ca5989ab691a6f7aae26c972cd3cab173b7354a3]: Split one big widget.c into set of files
  • [31084e65b68e5d3ef2d37780dc0cf923b0b6e1bd]: Added scrollbar widget. Also, added scrollbar into panel and listbox widgets.

Review, please.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 14:43 UTC (comment 13)

  • [ac6fdc4d5d42c5df3e026779be7cca39636d6e2f]: Fix segfault if no entryes for scrolling

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 20:00 UTC (comment 14)

  • [10bc96adb96651f84593b67c759fcaa97db9d127]: Added option 'show scrollbar' into 'Layout' config

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 21, 2009 at 7:22 UTC (comment 15)

  • Severity changed from on review to on rework

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 21, 2009 at 9:56 UTC (comment 16)

  • Milestone changed from 4.7.0-pre4 to 4.7

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Feb 4, 2010 at 9:14 UTC (comment 17)

  • Cc changed from dborca@….com to dborca@….com, gotar@….pl

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 29, 2011 at 16:54 UTC (comment 18)

  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 10, 2014 at 12:24 UTC

@mc-butler
Copy link
Author

Changed by kybl (@kybl) on Jul 10, 2020 at 6:21 UTC (comment 20)

  • Cc changed from dborca@….com, gotar@….pl to dborca@….com, gotar@….pl, ales.janda@….cz

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 18, 2021 at 12:43 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaz slavaz

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.7.0-pre1 Reproducible in version 4.7.0-pre1
Milestone
Future Releases
Development

No branches or pull requests
2 participants
@slavaz @mc-butler