Option Whole words in Find, Editor

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1487
Reporter	dborca (dborca@….com)
Mentions	dborca@….com, dmartina@….com
Keywords	whole, words

There are a few things which came with the new search engine:

1. A bug in src/search/regex.c prevents using \b in regex search. There's a duplicate of \B.
2. There's no "Whole Words Only" option. One could use regex search with \btext\b, but see the bug above. Besides, it would be nice to have a quick "Whole Words Only" checkbox for text searches. I sometimes find it useful, even in File Find (a la "grep -rw").

Note

Original attachments:

• mc-4.7.0-pre1.search.patch.gz (raw) by dborca (dborca@….com) on Aug 6, 2009 at 22:49 UTC
• mc-4.7.0-pre1.search.patch (raw) by angel_il (@ilia-maslakov) on Aug 7, 2009 at 5:33 UTC
• find.c.patch (raw) by dmartina (dhmartina@….es) on Aug 7, 2009 at 8:15 UTC

[mc-butler]

Changed by dborca (dborca@….com) on Aug 6, 2009 at 22:49 UTC

• Attachment mc-4.7.0-pre1.search.patch.gz (raw) added

[mc-butler]

Changed by dborca (dborca@….com) on Aug 6, 2009 at 23:58 UTC (comment 1)

• Cc set to dborca@….com

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 7, 2009 at 4:29 UTC (comment 2)

Pleas split your patch to several independent parts and reopen the according tickets.
And again, please don't attach gzip'ed patches.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 7, 2009 at 5:33 UTC

• Attachment mc-4.7.0-pre1.search.patch (raw) added

[mc-butler]

Changed by dmartina (dhmartina@….es) on Aug 7, 2009 at 8:15 UTC (comment 3)

• Blocking set to #1370
• Cc changed from dborca@….com to dborca@….com, dmartina@….com

Be careful with i18n! See patch about "First hit".

[mc-butler]

Changed by dmartina (dhmartina@….es) on Aug 7, 2009 at 8:15 UTC

• Attachment find.c.patch (raw) added

Missing runtime i18n of new "First Hit" label

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 7, 2009 at 9:04 UTC (comment 4)

• Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 7, 2009 at 9:15 UTC (comment 5)

Find file bugs are fixed in reopened #1457. See #1457 comment 17

[mc-butler]

Changed by dmartina (dhmartina@….es) on Aug 7, 2009 at 21:59 UTC (comment 6)

• Blocking #1370 deleted

"First hit" does translate.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 10, 2009 at 7:13 UTC (comment 7)

• Milestone changed from 4.7.0-pre3 to 4.7.0-pre2

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 22, 2009 at 6:50 UTC (comment 8)

• Status changed from new to accepted
• Owner set to angel_il

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 22, 2009 at 8:36 UTC (comment 9)

• Description edited

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 22, 2009 at 11:10 UTC (comment 10)

• Keywords set to whole, words

branch 1487_whole_words (parent: master)
changeset: [14d668dcf33d2db5eff58c9b98442810586b8235]

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 22, 2009 at 11:10 UTC (comment 11)

• Severity changed from no branch to on review

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 22, 2009 at 11:13 UTC (comment 12)

• Summary changed from Search improvements/bugfixes in Find, Editor, View to Option Whole words in Find, Editor

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 22, 2009 at 11:19 UTC (comment 13)

changeset: [156b796] (forced update)

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 23, 2009 at 9:23 UTC

• Blocking set to #1560

[mc-butler]

Changed by iNode (@iNode) on Aug 23, 2009 at 10:13 UTC (comment 14)

• Blocking #1560 deleted
• Votes set to iNode

Looks good.

[mc-butler]

Changed by iNode (@iNode) on Aug 23, 2009 at 10:14 UTC (comment 15)

• Blocking set to #1560

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 23, 2009 at 14:31 UTC (comment 16)

• Severity changed from on review to approved
• Votes changed from iNode to iNode andrew_b

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 23, 2009 at 14:38 UTC (comment 17)

• Resolution set to fixed
• Severity changed from approved to merged
• Votes changed from iNode andrew_b to commited-master
• Status changed from accepted to testing

Fixed: [156b796]

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 23, 2009 at 15:21 UTC (comment 18)

• Status changed from testing to closed
• Description edited

[mc-butler]

Changed by andrew_b (@aborodin) on Sep 3, 2009 at 12:39 UTC

• Blocking #1560 deleted

[mc-butler]

Changed by zaytsev (@zyv) on Feb 21, 2025 at 7:18 UTC (comment 20)

Ticket #1495 has been marked as a duplicate of this ticket.