-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple viewers and editors open concurrently with the file manager #1490
Comments
|
|
Please, don't include diffs of autogenerated stuff (Makefile.in, config.h.in, configure) into patches. |
and please dont gzip files before attach :) |
|
|
Replying to slavazanko:
No. It is much, much better. :) |
i see :) |
Replying to angel_il:
That is handled by dlgswitch_before_exit(). The user is automatically switched to all editors with unsaved files (all others are closed). Switching is disabled when doing this, to prevent the user to do "smart" things. :) |
Replying to angel_il:
Sorry, I just saw that I answered earlier what happens when Midnight will close. But probably you already knew that. :)
You asked "when the terminal will close". Well, the files remain unsaved and locks are left behind. But that is not a new problem, because I ask you: currently, when we have only one editor instance, what will happen with unsaved opened file when the terminal will close? It's just the same. |
Replying to dborca:
yes, of course. Because I think about this many times. :)
When only one file is opened i will see that it is not saved. It's eyse... |
branch: 1490_dlgswitch (parent: master) |
Patch and branch must be reworked to use glib functions as much as possible. |
Also src/dlgswitch.[ch] are not in the branch. |
in dlgswitch.c i see:
you mean:
Copyright (C) 2009 Free Software Foundation, Inc.
? |
Yep. You can change that. |
Replying to dborca:
ok :), i'll fix it in branch... |
without a written (on paper!) copyright assignment, dborca's copyright notice is the only legally relevant one anyway. of course, that applies equally to all code written by anyone else who did not sign such a paper. |
|
|
|
|
Created 1490_multi_screens branch. Parent branch is master. |
Rebased to current master. |
|
|
Merged to master.
|
|
Exit from subshell is handled incorrectly.
Created 1490_exit_subshell_fix branch. Parent branch is master. |
|
|
Multi-screen angine doesn't handle correctly some cases.
6a. The 1st editor is highlighted as current screen. This is wrong. Current screen is file panels. |
Just for the record: the same is true for viewers.
And, by the way, when you open Meta+` the cursor is blinking in a strange place. I would have expected it to blink in the lower bottom corner. However, the same is true for F2 dialog, so it's not a multiscreen problem as such. |
Created 1490_multiscreen_fix branch. Parent branch is master. |
|
|
Merged to master. |
Important
This issue was migrated from Trac:
dborca
(dborca@….com)dborca@….com
Ok, this is my second-favourite patch :)
A nice feature of Advanced Midnight Commander mc-4.1.x-MP by Olegarch was the dialog selector. It allowed the user to have multiple viewers and editors open along with the main file manager. They can be switched at will. Note that this does NOT imply multi-threading, because there's no point for editors, viewers and file-managers to run in background; they primarily need user interaction.
The hotkeys for Multi Screen feature:
"M-`" selector
"M-," switch to previous
"M-." switch to next
Yes, I know the hotkeys are not very well-chosen, but I really tried hard to avoid clashes with existing hotkeys. (I just saw M-. was taken in GIT, but honestly, I don't need a hotkey to switch hidden files on and off very frequently; I can live with just a setting in Options for that :))
Patch (against 4.7.0-pre1) attached.
Note
Original attachments:
dborca
(dborca@….com) onAug 6, 2009 at 23:52 UTC
angel_il
(@ilia-maslakov) onAug 7, 2009 at 5:23 UTC
The text was updated successfully, but these errors were encountered: