Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create menu dynamically #1563

Closed
mc-butler opened this issue Aug 24, 2009 · 14 comments
Closed

Create menu dynamically #1563

mc-butler opened this issue Aug 24, 2009 · 14 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1563
Reporter andrew_b (@aborodin)

Currently, menu creates as static arrays. This doesn't provide flexible menu operations in run-time: added or remove some items. At this time it is not needed, but in future... Who knows? :)
The proposition is: create menus as items of dynamic arrays (GPtrArray).

Branch: HACK_menu. Initial [5d2ceeac1989b381f169441c6f463ceeee38977a]

Some visual features:

  • for each drop menu, the selected item is saved;
  • Home and End keys are handled.

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 24, 2009 at 12:49 UTC (comment 1)

  • Status changed from new to accepted
  • Owner set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 8, 2009 at 9:32 UTC

  • Blocking set to #320

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 3, 2009 at 4:02 UTC

(In #1654) Home/End keys are handled in #1563.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 3, 2009 at 11:45 UTC (comment 4)

Also, after #212 need to show actual hotkey from keybindings-file

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 3, 2009 at 14:02 UTC

(In #1653) Accelerators in editor main menu are implemented in #1563.
Please wait for merge that branch into master one.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 3, 2009 at 14:04 UTC (comment 6)

  • Milestone changed from 4.7 to 4.7.0-pre4

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Oct 8, 2009 at 15:00 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 26, 2009 at 8:00 UTC (comment 7)

  • Severity changed from no branch to on review

Branch HACK_menu.
Inital [97a510a72eef154f60a3ea2515ff8b9e4bff4d9d]

Please review.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 26, 2009 at 8:37 UTC (comment 8)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Oct 26, 2009 at 12:54 UTC (comment 9)

  • Severity changed from on review to approved
  • Votes changed from slavazanko to slavazanko angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 26, 2009 at 13:19 UTC (comment 10)

  • Severity changed from approved to merged
  • Votes changed from slavazanko angel_il to commited-master

Merged to master.

git log --pretty=oneline a563b5d..21fd13b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 26, 2009 at 13:19 UTC (comment 11)

  • Resolution set to fixed
  • Status changed from accepted to testing

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 26, 2009 at 13:20 UTC (comment 12)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 26, 2009 at 13:22 UTC (comment 13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Development

No branches or pull requests

2 participants