Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded colours #1667

Closed
mc-butler opened this issue Oct 3, 2009 · 10 comments
Closed

Hardcoded colours #1667

mc-butler opened this issue Oct 3, 2009 · 10 comments
Assignees
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around ver: 4.7.0-pre3 Reproducible in version 4.7.0-pre3
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1667
Reporter gotar (gotar@….pl)

BOOK_MARK_COLOR and BOOK_MARK_FOUND_COLOR are hardcoded in edit/edit-widget.h and so cannot be changed via skin.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 7, 2009 at 13:40 UTC (comment 1)

  • Status changed from new to accepted
  • Milestone changed from 4.7 to 4.7.0-pre4
  • Owner set to slavazanko

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 7, 2009 at 13:44 UTC (comment 2)

related bug: #1559

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 12, 2009 at 15:20 UTC (comment 3)

  • Severity changed from no branch to on review

created branch 1667_hardcoded_colors

initial [48cb06c1b7e324728c16901a580e478b9f3c6d9e]

Review, please.

@mc-butler
Copy link
Author

Changed by iNode (@iNode) on Oct 13, 2009 at 9:04 UTC (comment 4)

Isn't should be default values specified?
(or 0 is correct default value?)

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 13, 2009 at 9:31 UTC (comment 5)

if no any values specified, then this is equal to [section_name]._default_

In this case, these colorpairs will equal to editor._default_ (lightgray;blue)

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Oct 22, 2009 at 11:49 UTC (comment 6)

  • Votes set to angel_il

initial: [873de2390ddd863e0a7ec4fbab784446b630ff06] (forced update)

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 22, 2009 at 11:55 UTC (comment 7)

  • [0391ebd772225bde014d185f121107a4709aa7c4]: Fix colors showing for compile with S-Lang library

Review, please.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 24, 2009 at 13:26 UTC (comment 8)

  • Votes changed from angel_il to angel_il andrew_b
  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 24, 2009 at 13:41 UTC (comment 9)

  • Severity changed from approved to merged
  • Status changed from accepted to testing
  • Votes changed from angel_il andrew_b to commited-master
  • Resolution set to fixed

merge [20cd37d]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 24, 2009 at 13:41 UTC (comment 10)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around ver: 4.7.0-pre3 Reproducible in version 4.7.0-pre3
Development

No branches or pull requests

2 participants