Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Quick view shortcut printed in menu, wrong shortcuts for File #1764

Closed
mc-butler opened this issue Oct 31, 2009 · 11 comments
Closed

No Quick view shortcut printed in menu, wrong shortcuts for File #1764

mc-butler opened this issue Oct 31, 2009 · 11 comments
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around ver: 4.7.0-pre4 Reproducible in version 4.7.0-pre4
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1764
Reporter gotar (gotar@….pl)

Left/Right menu always had "Quick view C-x q" entry, now it's only "Quick view", while the shortcut was not changed and still works.
File manu contains wrong info for:
Delete F6 instead of F8
Select group M-* instead of just "+"
Unselect group Gray+ instead of just "-"
Reverse selection Gray- instead of "*"
and
Quick cd M-c
disappeared entirely.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 11, 2009 at 9:22 UTC

Replying to gotar (#1764):

Left/Right menu always had "Quick view C-x q" entry, now it's only "Quick view", while the shortcut was not changed and still works.

Unconfirmed.

File manu contains wrong info for:

Delete F6 instead of F8

Unconfirmed.

Select group M-* instead of just "+"

Unconfirmed.

Unselect group Gray+ instead of just "-"

Unconfirmed.

Reverse selection Gray- instead of "*"

Unconfirmed.

and

Quick cd M-c

disappeared entirely.

Unconfirmed.

But prefix "Gray" is correct for "Gray+", "Gray-" and "Gray*" shortcuts.

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Nov 11, 2009 at 15:14 UTC (comment 2)

I don't know how it is possible that your menu differs from mine, but "Gray" prefix although correct is simply not required as mentioned functions do work with plain [+-*].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 12, 2009 at 13:11 UTC (comment 2.3)

Replying to gotar:

I don't know how it is possible that your menu differs from mine,

Me too. Are shortcuts correct in Command menu?

but "Gray" prefix although correct is simply not required as mentioned functions do work with plain [+-*].

Ok, I'll remove "Gray" from shortcuts.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 14, 2009 at 9:15 UTC

  • Description edited

Replying to gotar (#1764):

Delete F6 instead of F8

You are right. This default shortcut string is wrong. But it is occured if /etc/mc/mc.keymap file is absent. Fixed in 212_buttonbar_commands branch.

Select group M-* instead of just "+"
Unselect group Gray+ instead of just "-"
Reverse selection Gray- instead of "*"

Also fixed in 212_buttonbar_commands branch.

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Nov 14, 2009 at 12:40 UTC (comment 5)

Yes, shortcuts are correct in Command menu and yes - I do all the checks with no configuration files, just plain mc binary. With mc.keymap menu indeed everything is correct.
One more mistake I haven't reported yet is "Exit C-x C-c" while only F10 exits.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 14, 2009 at 14:10 UTC (comment 5.6)

Replying to gotar:

One more mistake I haven't reported yet is "Exit C-x C-c" while only F10 exits.

This shortcut is present in MC code, but seems doesn't work very long time.
Fixed in 212_buttonbar_commands branch.

Great thanks!

But what about

Quick cd M-c
disappeared entirely.

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Nov 15, 2009 at 10:20 UTC (comment 6.7)

Great thanks!

You are welcome:)

But what about

Quick cd M-c
disappeared entirely.

I must have overlooked this one, it's on it's place.

And I've found similar things in editor:
File/New C-x k instead C-n
Edit/Beginning M-< instead C-PgUp
Edit/End M-> instead C-PgDn
Search/Search again S-F6 instead S-F7

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 16, 2009 at 13:39 UTC (comment 7.8)

  • Blocked by set to #212
  • Milestone changed from 4.7 to 4.7.0

Replying to gotar:

And I've found similar things in editor:
File/New C-x k instead C-n
Edit/Beginning M-< instead C-PgUp
Edit/End M-> instead C-PgDn
Search/Search again S-F6 instead S-F7

Fixed in 212_buttonbar_commands branch.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 19, 2009 at 7:03 UTC

  • Blocked by #212 deleted

(In #212) Merged to master.

git log --pretty=oneline 9531266..6f3b00c

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 19, 2009 at 7:04 UTC (comment 10)

  • Status changed from new to closed
  • Resolution set to fixed

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 19, 2009 at 7:04 UTC (comment 11)

  • Severity changed from no branch to merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around ver: 4.7.0-pre4 Reproducible in version 4.7.0-pre4
Development

No branches or pull requests

1 participant