Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide cursor when menu opened #1771

Closed
mc-butler opened this issue Oct 31, 2009 · 15 comments
Closed

Hide cursor when menu opened #1771

mc-butler opened this issue Oct 31, 2009 · 15 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around ver: 4.7.0-pre4 Reproducible in version 4.7.0-pre4
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1771
Reporter sergey-feo (sergey-feo@….ru)
  1. Please press F9 to open menu.
  2. Open "Left" item.
  3. Item "Listing mode" will be selected. Move cursor to "FTP link" item with down arrow key.

Selected item "FTP link" is colored in 2 ways:
1) All string "FTP link" is colored;
2) First symbol "F" is colored.

I suggest disable coloring of first symbol. It make view more clear IMHO.

Please see attached screenshots also.

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by sergey-feo (sergey-feo@….ru) on Oct 31, 2009 at 15:47 UTC

@mc-butler
Copy link
Author

Changed by sergey-feo (sergey-feo@….ru) on Oct 31, 2009 at 15:48 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 31, 2009 at 16:53 UTC (comment 1)

There is an alternative proposal: place cursor on the menu item hotkey (as in button).

@mc-butler
Copy link
Author

Changed by sergey-feo (sergey-feo@….ru) on Oct 31, 2009 at 17:27 UTC (comment 2)

This alternative will save unneeded additional coloring. Such coloring makes menu's view inaccurate IMHO.

@mc-butler
Copy link
Author

Changed by sergey-feo (sergey-feo@….ru) on Oct 31, 2009 at 17:28 UTC (comment 3)

By the way: a suggest to disable cursor on buttons too.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 10, 2010 at 6:21 UTC (comment 4)

  • Type changed from task to enhancement
  • Severity changed from no branch to on review
  • Milestone changed from Future Releases to 4.7.3
  • Owner set to andrew_b
  • Status changed from new to accepted

Created 1771_menu_hide_cursor branch. Parent branch is master.
[9139a1c9e4a35d8c2c3c7d7a65d2b5139f7b05c9]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on May 11, 2010 at 5:48 UTC (comment 5)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 21, 2010 at 20:45 UTC (comment 6)

  • Votes angel_il deleted

Branch rebased into current master and added some changes:

  • [7c018bb00fdc0f14cffa3857865943e50c979f01]: don't show cursor in menu.
  • [f5dd9b7afb990890f9a0040cbcae67049024aad2]: Code cleanup for compile with -Werror option
  • [206c6460f01033c97c3a7607c0f26826d7780b43]: don't show cursor in listboxes

Review again, please.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 22, 2010 at 7:31 UTC (comment 7)

[f5dd9b7afb990890f9a0040cbcae67049024aad2]: Code cleanup for compile with -Werror option

362	 	    int i = sizeof (s_split_direction) / sizeof (char *); 
 	362	    off_t i = sizeof (s_split_direction) / sizeof (char *); 
511	 	    int i; 
 	511	    off_t i; 

Why off_t but not size_t?

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 24, 2010 at 8:57 UTC (comment 8)

Why off_t but not size_t?

See [a601e0598742a12c5aae74f7571a719c409ec158]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 24, 2010 at 9:22 UTC (comment 9)

  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on May 25, 2010 at 18:21 UTC (comment 10)

  • Votes changed from andrew_b to andrew_b angel_il

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on May 25, 2010 at 18:21 UTC (comment 11)

  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 26, 2010 at 6:12 UTC (comment 12)

  • Status changed from accepted to testing
  • Votes changed from andrew_b angel_il to committed-master
  • Resolution set to fixed
  • Severity changed from approved to merged

Merged to master.
[6117c5b]

git log --pretty=oneline f513925..6117c5b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 26, 2010 at 6:12 UTC (comment 13)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around ver: 4.7.0-pre4 Reproducible in version 4.7.0-pre4
Development

No branches or pull requests

2 participants