Various build fixups (missing includes, name clashes, ...)

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1774
Reporter	metux (@metux)
Keywords	build, -Werror, includes, name-conflicts

There are several unclean things which break build in -Werror mode, eg: char* vs const char* mixups, missing includes, conflicting variable names, etc.

branch:1774_build_cleanups
[4a1e9c124c6028307be260bb8d2e0c0e516a2c1a]

[mc-butler]

Changed by metux (@metux) on Oct 31, 2009 at 19:35 UTC (comment 1)

• Severity changed from no branch to on review
• Owner set to metux
• Status changed from new to accepted

[mc-butler]

Changed by metux (@metux) on Oct 31, 2009 at 19:43 UTC (comment 2)

• Priority changed from major to blocker

[mc-butler]

Changed by slavazanko (@slavaz) on Nov 2, 2009 at 9:43 UTC (comment 3)

• Votes set to slavazanko

Branch for this ticket: 1774_build_cleanups

Looks good.

[mc-butler]

Changed by slavazanko (@slavaz) on Nov 2, 2009 at 9:43 UTC (comment 4)

• Milestone changed from 4.7 to 4.7.0

[mc-butler]

Changed by slavazanko (@slavaz) on Nov 2, 2009 at 10:03 UTC (comment 5)

• Votes slavazanko deleted

My latest correct [f91d4aa1ac6e07ecb10b47abd7e642619b749036]

Changed include 'glib.h' to 'global.h' besause global.h file have some things for backward compability with glib (eg. including 'glibcompat.h')

Review.

[mc-butler]

Changed by slavazanko (@slavaz) on Nov 2, 2009 at 10:18 UTC (comment 6)

Also, branch rebased for more WorkingGuideLines-complicant

Added Ticket number in first commit of branch.

Initial [083d3546a6979c81e2a2a728b4b832fa6e2ed144]

[mc-butler]

Changed by metux (@metux) on Nov 3, 2009 at 23:37 UTC (comment 7)

• Description edited

Rebased to current master

[mc-butler]

Changed by iNode (@iNode) on Nov 4, 2009 at 14:32 UTC (comment 8)

• Votes set to iNode

[mc-butler]

Changed by slavazanko (@slavaz) on Nov 4, 2009 at 15:35 UTC (comment 9)

• Severity changed from on review to approved
• Votes changed from iNode to iNode slavazanko

[mc-butler]

Changed by metux (@metux) on Nov 9, 2009 at 12:48 UTC (comment 10)

• Description edited
• Severity changed from approved to merged

rebased and merged into master

[mc-butler]

Changed by metux (@metux) on Nov 11, 2009 at 11:05 UTC (comment 11)

• Status changed from accepted to testing
• Resolution set to fixed

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 11, 2009 at 13:42 UTC (comment 12)

• Status changed from testing to closed
• Votes changed from iNode slavazanko to commited-master

git log --pretty=oneline d740efc...de4e40d