src_keybindC_mistakes

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1824
Reporter	vit_r (vit_r@….ru)

Note

Original attachments:

• 1824-src_keybindC_mistakes.patch (raw) by vit_r (vit_r@….ru) on Nov 13, 2009 at 22:42 UTC

[mc-butler]

Changed by vit_r (vit_r@….ru) on Nov 13, 2009 at 22:42 UTC

• Attachment 1824-src_keybindC_mistakes.patch (raw) added

[mc-butler]

Changed by vit_r (vit_r@….ru) on Nov 13, 2009 at 22:47 UTC (comment 1)

• Component changed from mcview to mcedit

By the way

Is this line (src/keybind.c: 669) correct:

{ XCTRL ('@'), CK_SingleDirsizeCmd, "C-Space" },

And these:
const global_keymap_t default_viewer_keymap[] = {

{ 'h', CK_ViewMoveLeft, "h" },
{ KEY_LEFT, CK_ViewMoveLeft, "Left" },

{ 'l', CK_ViewMoveRight, "l" },
{ KEY_RIGHT, CK_ViewMoveRight, "Right" },

{ 'r', CK_ViewNewBookmark, "r" },

may have a more logical look, for example :

{ 'l', CK_ViewMoveLeft, "l" },
{ KEY_LEFT, CK_ViewMoveLeft, "Left" },

{ 'r', CK_ViewMoveRight, "r" },
{ KEY_RIGHT, CK_ViewMoveRight, "Right" },

{ 'n', CK_ViewNewBookmark, "n" },

because when

'l' is CK_...Right

it puzzles, but may be some deeper reasons ... ?

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 14, 2009 at 8:47 UTC (comment 2)

attachment 1824-src_keybindC_mistakes.patch added

Thanks! Fixed in 212_buttonbar_commands branch.

[mc-butler]

Changed by vit_r (vit_r@….ru) on Nov 14, 2009 at 9:25 UTC (comment 2.3)

Replying to andrew_b:

attachment 1824-src_keybindC_mistakes.patch added

Thanks! Fixed in 212_buttonbar_commands branch.

You mean my msg has something new ?
And when 212_* will be merged to 'master' ?
For example edit.c has a lot of declarations to be corrected
like int line -> long line
but may be they are fixed already ?
The question is:
Where are fixings gathered ?

Excuse me for ignorance

Vit

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 14, 2009 at 10:04 UTC (comment 3.4)

Replying to vit_r:

Replying to andrew_b:
You mean my msg has something new ?

Yes.

And when 212_* will be merged to 'master' ?

When #212 will get the second vote from one of MC developers.

For example edit.c has a lot of declarations to be corrected
like int line -> long line
but may be they are fixed already ?

No. That fixes require new ticket.

The question is:
Where are fixings gathered ?

One ticket is for one fix (or several related fixes).

[mc-butler]

Changed by vit_r (vit_r@….ru) on Nov 14, 2009 at 12:34 UTC (comment 5)

Ohh ...
Great: its much more clear
Big-big THANKS

That fixes

some are on the way right now

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 23, 2009 at 12:31 UTC (comment 6)

• Milestone changed from 4.7 to 4.7.0
• Status changed from new to closed
• Version changed from 4.7.0-pre4 to master
• Resolution set to fixed

802 { KEY_F (8), CK_DeleteCmd, "F6" },

already fixed in 'master'