slow mcedit after utf8 support added

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1843
Reporter	richlv (richlv@….net)

mcedit is notably slow in latest releases, for example, simply scrolling down a few kb large file produces delays. according to #1417 comment 14 - because of utf8 support.

companion bug of ticket #1417 (which concerns mcview)

Note

Original attachments:

• forms.inc.php.bz2 (raw) by richlv (richlv@….net) on Dec 23, 2009 at 13:53 UTC

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 23, 2009 at 12:27 UTC (comment 1)

please attach the problem file. may be trouble in color scheme...

[mc-butler]

Changed by richlv (richlv@….net) on Dec 23, 2009 at 13:53 UTC

• Attachment forms.inc.php.bz2 (raw) added

testcase

[mc-butler]

Changed by richlv (richlv@….net) on Dec 23, 2009 at 13:53 UTC (comment 2)

situation is notably improved after the last mc upgrade in slackware-current.
attaching one file where opening it and holding pgdown shows some slowness still

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 23, 2009 at 15:42 UTC (comment 3)

what terminal (terminal emulator) you use? gnome-terminal?

[mc-butler]

Changed by richlv (richlv@….net) on Dec 23, 2009 at 16:02 UTC (comment 4)

konsole 1.6.6, on kde 3.5.10

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 23, 2009 at 17:15 UTC (comment 5)

cp forms.inc.php forms.inc.php.c
mcedit forms.inc.php.c

maybe trouble in php.syntax or color parser...

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 23, 2009 at 17:49 UTC (comment 6)

i try edit your file forms.inc.php in 4.6.1 with current php.syntax. i don't see regression. 4.7.0 so slowly as 4.6.1 with current php.syntax

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 25, 2009 at 16:48 UTC (comment 7)

• Severity changed from no branch to on review

branch: 1843_slow_edit
changeset: [1e85261d3eb5ef5c919875fb26de585fff9fc796]

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 25, 2009 at 17:52 UTC (comment 8)

• Milestone changed from 4.7 to 4.7.0

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 25, 2009 at 17:56 UTC (comment 9)

• Milestone changed from 4.7.0 to 4.7.1

[mc-butler]

Changed by metux (@metux) on Dec 26, 2009 at 21:56 UTC (comment 10)

• Votes set to metux

[mc-butler]

Changed by metux (@metux) on Dec 26, 2009 at 22:09 UTC (comment 11)

• Blocked by set to #1872

Buildfarm test still failed, since #1872 not merged yet ;-O

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 28, 2009 at 7:58 UTC (comment 12)

Does this branch introduce new compile warnings? If not, please remove 'Blocked by'.

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 5, 2010 at 9:20 UTC (comment 13)

• Blocked by #1872 deleted

Rebased to current master.
[39ddea8]
[b881a7b]

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 5, 2010 at 9:49 UTC (comment 14)

• Severity changed from on review to approved
• Votes changed from metux to metux slavazanko

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 5, 2010 at 10:00 UTC (comment 15)

• Status changed from new to closed
• Votes changed from metux slavazanko to commited-master
• Severity changed from approved to merged
• Resolution set to fixed

Merged to master.

git log --pretty=oneline e6dce1d..b925016