savannah: recursive "are same file"

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/19
Reporter	ossi (@ossilator)

This patch solve the trouble:
1) in panel select any dir
2) F5 (copy dialog)
3) in field copy to insert "."
4) done

we have error for some file in this subdir and no way leave.

Now show dialog with [ Abort ] [ Skip ] buttons.

Original: http://savannah.gnu.org/bugs/?13727

Submitted by:	Oswald Buddenhagen <ossi>	Submitted on:	Mon 11 Jul 2005 03:34:08 PM UTC
Category:	Core	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	current (CVS or snapshot)	Operating System:	All

Original submission:

recently i accidentally entered "." instead of ".." in the file 
copy dialog on a relatively big tree ... for every f***ing file in 
the tree i got the "<foo> and <bar> are the same file" message box, 
without any way to escape except killing mc from the outside. 

Comment 1 by Pavel Tsekov <ptsekov> at Tue 12 Jul 2005 11:56:05 AM UTC:

What do you think should be done in this case ?

1) Silently ignore the fact and continue

2) Pop up a box with several choices

3) Something else

Comment 2 by Oswald Buddenhagen <ossi> at Tue 12 Jul 2005 12:53:06 PM UTC:

well, one could simply do this same-inode check on directories as 
well. this would give exactly the desired effect - one error 
message box (for the top-level directory) and bye bye.

Comment 3 by Pavel Tsekov <ptsekov> at Sat 19 May 2007 01:43:08 PM UTC:

Denis Vlasenko posted a patch which would fix this issue:

http://mail.gnome.org/archives/mc-devel/2007-May/msg00033.html

Note

Original attachments:

• mc_samefile_abort.diff (raw) by slavazanko (@slavaz) on Dec 25, 2008 at 12:21 UTC
• mc_samefile_abort.2.diff (raw) by angel_il (@ilia-maslakov) on Mar 5, 2009 at 9:04 UTC
• 0001-Denis-Vlasenko-posted-a-patch-which-would-fix-issue.patch (raw) by angel_il (@ilia-maslakov) on Mar 5, 2009 at 9:49 UTC

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 25, 2008 at 12:21 UTC

• Attachment mc_samefile_abort.diff (raw) added

patch that fix this bug

[mc-butler]

Changed by winnie (@winnieXY) on Jan 30, 2009 at 13:27 UTC (comment 1)

• Milestone set to 4.6.3

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 5, 2009 at 9:04 UTC

• Attachment mc_samefile_abort.2.diff (raw) added

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 5, 2009 at 9:49 UTC

• Attachment 0001-Denis-Vlasenko-posted-a-patch-which-would-fix-issue.patch (raw) added

last version master based

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 5, 2009 at 10:09 UTC (comment 2)

• Keywords set to review
• Status changed from new to accepted
• Description edited
• Owner set to angel_il

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 5, 2009 at 10:18 UTC (comment 3)

created branch 19_show_abort_skip_for_copy_error; parent branch: master

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 8, 2009 at 11:09 UTC (comment 4)

src/file.c:

• modified error messages for warn_same_file() function;
• move_dir_dir(): fixed memory leak: destdir is not free'd when the same directory is copied;
• move_dir_dir(): don't use the non-valid dbuf variable if mc_stat(d, &dbuf) returns non-zero.

Fixed types of file/dir operation functions.
All po/*po files are updated to sync with modified src/file.c file.

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 12, 2009 at 8:51 UTC (comment 5)

• Keywords changed from review to review, vote-slavazanko

cool. Looks good. 'Abort' action very useful in this case.
My vote here

[mc-butler]

Changed by styx (@styx) on Mar 12, 2009 at 9:08 UTC (comment 6)

• Keywords changed from review, vote-slavazanko to vote-slavazanko, vote-styx, approved

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 17, 2009 at 6:59 UTC (comment 7)

• Status changed from accepted to assigned

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 17, 2009 at 20:11 UTC (comment 8)

• Keywords changed from vote-slavazanko, vote-styx, approved to commited-mc-4.6
• Status changed from assigned to testing
• Resolution set to fixed

[mc-butler]

Changed by winnie (@winnieXY) on Mar 20, 2009 at 7:02 UTC (comment 9)

• Status changed from testing to closed

[mc-butler]

Changed by mc-butler (@mc-butler) on Jul 31, 2009 at 22:13 UTC

• Milestone 4.6.2.1 deleted

Milestone 4.6.2.1 deleted

[mc-butler]

Changed by ossi (@ossilator) on Jan 11, 2014 at 15:43 UTC (comment 11)

• Branch state set to no branch
• Reporter changed from slavazanko to ossi
• Milestone set to Future Releases
• Description edited

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 12, 2014 at 7:20 UTC (comment 12)

• Milestone changed from Future Releases to 4.6.2
• Version set to 4.6.1
• Keywords commited-mc-4.6 deleted
• Branch state changed from no branch to merged