ISO9660 VFS doesn't recognize Joliet extension (losing long filenames)

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1963
Reporter	wjaguar (@wjaguar)

The version of ISO9660 VFS in mc 4.7.0.1 (mc-4.7.0.1/vfs/extfs/iso9660.in) is trying to use awk for string-matching-based tests, instead of grep which previous versions used, and is doing it wrong. As the result, the two tests always default to true, and isoinfo gets called with Joliet extensions and charset conversion both disabled.

And this abuse of awk was entirely unnecessary, for grep is perfectly able to do matching with alternation. Which is demonstrated by the attached bugfix.

Note

Original attachments:

• isofs.patch (raw) by wjaguar (@wjaguar) on Jan 14, 2010 at 23:13 UTC

[mc-butler]

Changed by slyfox (@trofi) on Jan 14, 2010 at 20:11 UTC (comment 1)

May I ask you to attach some simple small crafted ISO to check on?

[mc-butler]

Changed by wjaguar (@wjaguar) on Jan 14, 2010 at 21:28 UTC (comment 1.2)

Replying to slyfox:

May I ask you to attach some simple small crafted ISO to check on?

Cannot the simple fact that a shell expression like:
echo "nothing" | gawk "/UCS level 1|NO Joliet/" && echo "TRUE"
does in fact print "TRUE", while an expression:
echo "nothing" | grep "UCS level 1\|NO Joliet" && echo "TRUE"
doesn't, be verified without an ISO? :-)

Anyway, here is one: http://mtpaint.sourceforge.net/temp/showbug.iso

[mc-butler]

Changed by wjaguar (@wjaguar) on Jan 14, 2010 at 23:13 UTC (comment 3)

I updated the patch, so that it also gets rid of a spurious error message.

And regarding the original cause of #1485, which resulted in this breakage - the problem was really quite simple: in cdrtools 2.01.01 branch, isoinfo just could not use a nondefault encoding till version 2.01.01a68
So I suspect "UCS level 1" was never a problem by itself, and it just so happened that ISOs with non-latin filenames in original reporter's collection were made that way - "UCS level 3" ISOs produce all-underscores "names" too if the filenames are say cyrillic, and encoding is left at default (which is iso8859-1). Which means that when people upgrade to cdrtools 2.01.01a68 or later, for them the check for "UCS level 1" added in #1485 will act as a bug, not a feature.

[mc-butler]

Changed by wjaguar (@wjaguar) on Jan 14, 2010 at 23:13 UTC

• Attachment isofs.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 9, 2010 at 8:40 UTC (comment 4)

• Owner set to andrew_b
• Milestone changed from 4.7 to 4.7.5
• Status changed from new to accepted
• Severity changed from no branch to on review

Created 1963_iso9660 branch. Parent branch is master.
[3c85b567676b10b66e68eaf6e0af75bb331ff6c4]

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 9, 2010 at 10:48 UTC (comment 5)

• Votes set to angel_il

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 14, 2010 at 13:10 UTC (comment 6)

• Severity changed from on review to approved
• Votes changed from angel_il to angel_il slavazanko

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 14, 2010 at 13:18 UTC (comment 7)

• Votes changed from angel_il slavazanko to committed-master
• Resolution set to fixed
• Status changed from accepted to testing
• Severity changed from approved to merged

Merged to master.
[4de95fe]

Cherry-picked to 4.7.0-stable.
[d07692a75f13592be7dc6358732ac3653d74a1e5]

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 14, 2010 at 13:18 UTC (comment 8)

• Status changed from testing to closed